Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gamma r #1898

Merged
merged 7 commits into from
Nov 4, 2024
Merged

Rename gamma r #1898

merged 7 commits into from
Nov 4, 2024

Conversation

janinefreeman
Copy link
Collaborator

@janinefreeman janinefreeman commented Nov 3, 2024

Pull Request Template

Description

Rename gamma r variable in detailed PV models to gamma pmp, for clarity and consistency with actual naming conventions. Updates the CEC module library to use the new name. Also updated the version upgrade script for upgrading old files, and updated macros that use the old variable name.

Will require updates to CEC processing script and documentation @cpaulgilman

Fixes #210 . Goes with NREL/ssc#1231

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@janinefreeman janinefreeman added pv pvsam1, pvwatts, hcpv requires help revision Requires a Help revision before releasing public version labels Nov 3, 2024
@janinefreeman janinefreeman added this to the SAM Fall 2024 Release milestone Nov 3, 2024
Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The change to CEC Modules.csv seems to have changed the formatting of a couple of values (maybe by saving the CSV file from Excel?), but that will get overwritten by the new library for the release, so should be OK for now.

@janinefreeman janinefreeman merged commit 6156871 into develop Nov 4, 2024
8 checks passed
@janinefreeman janinefreeman deleted the renameGammaR branch November 4, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pv pvsam1, pvwatts, hcpv requires help revision Requires a Help revision before releasing public version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CEC Single Diode model: gamma_r should be renamed gamma_pmp
3 participants