Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ME cost, design feature additions #1423

Merged
merged 59 commits into from
Oct 18, 2023
Merged

ME cost, design feature additions #1423

merged 59 commits into from
Oct 18, 2023

Conversation

mjprilliman
Copy link
Collaborator

Description

  • Adds array cable voltage calculations to array page
  • Adds option for array scaling costs equations for each cost component (need to provide documentation)
  • Adds option to design own tidal turbine matching functionality of wind turbine design

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

mjprilliman and others added 30 commits December 1, 2022 09:13
* Update to Cambium 2022

* Update URL in webapis.conf.

* On UI form, read UUID from URL in webapis.conf instead of hard coding it. Future updates should only require updating the URL in webapis.conf.

* Revise tooltip descriptions to be Cambium version agnositc.

* Fix UI group box sizes so Merchant Plant Revenue page are all same size.

* Cambium sample script

* Update sample script to Cambium 2020.

* Update sample script to work for all PPA models, including Host Developer.

* Cambium macro button for PPA models

* Create macro based on sample script and add button to Revenue or Time of Delivery input page for all PPA models.

* Help revisions for Cambium 2022

* UI adjustments for Mac/Linux

* Update multiple year downloads for Cambium 2022

* Add optional escalation rate input and update defaults
* Support non-monotonic available years from Cambium (Cambium 2020 years were even years, Cambium 2022 varies)
* Update Help
* Update UI descriptions and tooltips

* Fix application of cambium escalation for copied data

* Fix cambium progress bar text

* Allow escalation for single-year download

* Help updates for cambium single-year escalation

* Fix input number format
* Migrate from wtk-srw-download to wtk-download

* Adds option to download subhourly wind resource data

* Fix intervals list

* Clean up WIND Toolkit download messages

* Fix string declarations and typo
Fix equation call to geothermal costs calculations
@mjprilliman mjprilliman added this to the SAM Fall 2023 Release milestone Jul 14, 2023
@mjprilliman mjprilliman self-assigned this Jul 14, 2023
@cpaulgilman
Copy link
Collaborator

Nice work on this! Here's some feedback from my tests.

Defaults

Default errors on load for following configurations:

  • MEwave / Single Owner
  • MEwave Battery / Single Owner
  • MEtidal / None

Array

Export cable voltage units are "kV AC" while inter-array and riser cable voltages are in kV. Either use AC/DC for all unit labels, or none.

Export cable voltage units kV HVDC is inconsistent with kV AC. For example, both 400 kV AC and 300 kV HVDC are both high voltage, but only the DC units use "HV". I would recommend using kVac and kVdc for all, (or kV AC and kV DC).

Note that user interface for other technologies uses convention of kVac instead of kV AC. I think we can use to use kV AC for marine energy, as long as it is consistent throughout all marine energy UI forms and documentation.

Tidal Energy Converter

Use separate forms and exclusive vars to load options from library_or_input_tidal radio buttons. For example see "Battery Dispatch Options FOM" form.

UI callback error when switching to "Import tidal converter" option.

Capital Cost Pages

Use same label for all R-value inputs. For example, Device Costs uses "Array scaling R-value" for column heading, but Structural Assembly cost breakdown uses "[Category name] cost scaling value".

The term "array scaling" is not clear. We can explain what it means in Help, or perhaps use different term if there is one that is clearer.

UI callback error on wave Capital Costs: BOS page when expanding "Development Cost Breakdown" panel.

Documentation Requirements for Help

Array

Description of Cable Specifications input options.

Definitions of new cable specification inputs:

  • Calculate cable lengths
  • Enter cable lengths
  • Inter-array cable voltage
  • Export cable voltage
  • Riser cable voltage
  • Use modeled voltage or choose voltage value
  • Offshore substation required
  • Calculate
  • Onshore substation required
  • Onshore substation voltage
  • Load grid voltage

Tidal Energy Converter

Description of new "Design tidal converter" option.

Definitions of new design converter inputs:

  • User-defined rated output, kW
  • User-defined rotor diameter, m
  • Number of rotors
  • PTO efficiency, %
  • Maximum Cp
  • Cut-in tidal surface velocity, m/s
  • Cut-out tidal surface velocity, m/s

Capital Cost Pages

Description of "use array scaling" option and equations.

Definitions of new cost inputs:

  • Array scaling R-value

@cpaulgilman
Copy link
Collaborator

@mjprilliman Updates since last push look good.

The default "Design tidal converter" option doesn't have a power curve. Do you want to set defaults for a valid power curve?

image

@mjprilliman mjprilliman merged commit 9900b74 into develop Oct 18, 2023
2 of 4 checks passed
@mjprilliman mjprilliman deleted the me_cost_array_scaling branch October 18, 2023 13:47
@mjprilliman mjprilliman mentioned this pull request Nov 2, 2023
@cpaulgilman cpaulgilman added the added to release notes PR and/or issue has been added to release notes for a public release label Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added to release notes PR and/or issue has been added to release notes for a public release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants