Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help revisions for Fall 2022 Beta release #1214

Merged
merged 1 commit into from
Oct 29, 2022
Merged

Conversation

cpaulgilman
Copy link
Collaborator

Additional revisions required before final release.

Update pv land area for #1127

Bifacial and spatial albedo.

GETEM revisions

Module efficiency per NREL/ssc#228

PVWatts versions in PVWatts top-level description: #1159

PDF / CDF tab P-value

PV uncertainty

Custom HTF optional properties

Capacity payments units.

Solar water heating change IAM coefficient label and remove total system flow rate.

Add link to PV smoothing preprint.

PV terrain slope clarification not available for non 1-axis tracking options.

NPV tips for interpreting NPV with links from other financial metrics.

LCOE calculator note about modeling incentives.

Battery results: Battery lifetime AC/DC units

Operating costs: Fix AC/DC units, revise escalation.

PV losses: Explain percentages for transformer losses, and list output variable names.

Grid outage explain battery SOC may go up to 100%: https://sam.nrel.gov/forum/forum-general/3977-battery-soc-when-constrained.html

Remove inputs browser link to parametrics youtube video.

Merchant plant: Note that revenue is zero if cleared capacity is zero for all time steps.

Revenue: Add link to CPUC procurement website for TOD factor library references

Replace "REopt Lite" with "REopt" per #1090

Inverter, Weighted Efficiency, update link to European weighted efficiency paper.

Generic CSP solar field area estimate in UI different from simulation value: https://sam.nrel.gov/forum/forum-general/3947

PV system design typo in tilt description suggestion to use parametrics: #1084

Fix dead link in Module NOCT temp model description to https://www.energy.ca.gov/programs-and-topics/programs/new-solar-homes-partnership-program-nshp

Self shading diffuse irradiance available for thin film and standard self-shading options since SAM 2020.2.29: https://sam.nrel.gov/forum/forum-general/3087

Pull Request Template

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This change modifies variables in existing compute modules. Please see Checking for PySAM Incompatible API Changes.

Checklist:

If you have added a new compute module in a SSC pull request related to this one, be sure to check the Process Requirements.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Additional revisions required before final release.

Update pv land area for #1127

Bifacial and spatial albedo.

GETEM revisions

Module efficiency per NREL/ssc#228

PVWatts versions in PVWatts top-level description: #1159

PDF / CDF tab P-value

PV uncertainty

Custom HTF optional properties

Capacity payments units.

Solar water heating change IAM coefficient label and remove total system flow rate.

Add link to PV smoothing preprint.

PV terrain slope clarification not available for non 1-axis tracking options.

NPV tips for interpreting NPV with links from other financial metrics.

LCOE calculator note about modeling incentives.

Battery results: Battery lifetime AC/DC units

Operating costs: Fix AC/DC units, revise escalation.

PV losses: Explain percentages for transformer losses, and list output variable names.

Grid outage explain battery SOC may go up to 100%: https://sam.nrel.gov/forum/forum-general/3977-battery-soc-when-constrained.html

Remove inputs browser link to parametrics youtube video.

Merchant plant: Note that revenue is zero if cleared capacity is zero for all time steps.

Revenue: Add link to CPUC procurement website for TOD factor library references

Replace "REopt Lite" with "REopt" per #1090

Inverter, Weighted Efficiency, update link to European weighted efficiency paper.

Generic CSP solar field area estimate in UI different from simulation value: https://sam.nrel.gov/forum/forum-general/3947

PV system design typo in tilt description suggestion to use parametrics: #1084

Fix dead link in Module NOCT temp model description to https://www.energy.ca.gov/programs-and-topics/programs/new-solar-homes-partnership-program-nshp

Self shading diffuse irradiance available for thin film and standard self-shading options since SAM 2020.2.29: https://sam.nrel.gov/forum/forum-general/3087
@cpaulgilman cpaulgilman added this to the SAM Fall 2022 Release milestone Oct 28, 2022
@cpaulgilman cpaulgilman self-assigned this Oct 28, 2022
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and pv uncertainty help and p50p90 open with correct forms!

@sjanzou sjanzou merged commit f53b2f4 into develop Oct 29, 2022
@sjanzou sjanzou deleted the help-beta-fall-2022 branch October 29, 2022 03:50
@cpaulgilman cpaulgilman restored the help-beta-fall-2022 branch October 29, 2022 12:35
@cpaulgilman cpaulgilman deleted the help-beta-fall-2022 branch October 29, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants