-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize and scale load profile, refactor (mostly heating) load code #454
Open
Bill-Becker
wants to merge
20
commits into
develop
Choose a base branch
from
norm-scale-load
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r monthly energy REopt will normalize kWh_ts/kWh_annual, just like the CRB data is, and then apply that normalized profile to the user-input annual or monthly energy value
Valid for load_type=[space_heating, dhw, process_heat] Not applicable for load_type=heating, which assumes the user wants separated space and DHW heating loads from a single load input
Instead of large data dump in the source code files which makes navigating the files cumbersome
…dhw to domestic_hot_water
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
normalize_and_scale_load_profile_input
which takes the input custom load profile (e.g.ElectricLoad.loads_kw
), normalizes it to timestep_energy/yearly_energy for each timestep, and then applies and scales that normalized profile to the input annual monthly energy values.annual_[energy]
data for CRBs by city/zone into .json files in thedata/load_profiles
folder, and then load that data within the load profile constructor functions (BuiltIn[Load]
) where they lived before (hard to navigate those load file with all that data).HeatingLoad
andBuiltInHeatingLoad
functions (3x2=6 functions down to 2) with a new argument of(heating_)load_type
.simulated_load
function for improved validation flow and adding thenormalize_and_scale_load_profile_input
option