Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erp fixes #269

Merged
merged 15 commits into from
Sep 23, 2023
Merged

Erp fixes #269

merged 15 commits into from
Sep 23, 2023

Conversation

hdunham
Copy link
Collaborator

@hdunham hdunham commented Sep 22, 2023 •
edited
Loading

Fixed

  • Fix backup_reliability_reopt_inputs(d, p, r) so doesn't ignore CHP from REopt scenario
  • In backup_reliability_reopt_inputs(d, p, r), get Generator and CHP fuel related values from REopt results Dict d and REoptInputs struct p, unless the user overrides the REopt results by providing generator_size_kw
  • Remove use of non-existent tech_upgraded Outages outputs, using tech_microgrid_size_kw instead
  • Added missing electric_storage_microgrid_upgraded to Outages results
  • Fix bug causing InexactError in num_battery_bins_default
  • Update docstrings in backup_reliability.jl

Changed

  • Changed backup_reliability results key from fuel_outage_survival_final_time_step to fuel_survival_final_time_step for consistency with other keys

@hdunham
Update backup_reliability.jl
bd4defa
@hdunham
correct batt efficiencies input names in docstrings
1d17ce0
@hdunham
update output name: fuel_survival_final_time_step
05255c8
@hdunham
Merge branch 'develop' into erp-fixes
9c1baee
@hdunham
add electric_storage_microgrid_upgraded to Outages outputs
de05ef0
@hdunham
replace use of non-existent storage_upgraded with electric_storage_mi…
efd0a7e 
…crogrid_upgraded
@hdunham
replace use of non-existent <tech>_upgraded in ERP
47b2632
@hdunham
use production_factor_series instead of summing dispatch series
8333b2d
@hdunham
correct calc of diesel gen size in backup_reliability_reopt_inputs
97a3ed9
@hdunham
use ternary operator instead of if else to avoid scope issues
37898b4
@hdunham
calc prime gen size in backup_reliability_reopt_inputs
2135a20
@hdunham
convert some reopt outputs from denseaxisarray to vector
1cc38b5
@hdunham
get erp generator inputs from reopt results/inputs backup_reliability…
b0a8a89 
…_reopt_inputs
@hdunham
don't production_factor_series instead of summing dispatch series
54b34aa
@hdunham hdunham merged commit c4e5535 into develop Sep 23, 2023
1 check passed
@Bill-Becker Bill-Becker mentioned this pull request Sep 23, 2023
Merged
rathod-b pushed a commit that referenced this pull request Mar 8, 2024
@hdunham
Merge pull request #269 from NREL/erp-fixes
5a785a2 
Erp fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bill-Becker Bill-Becker Bill-Becker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hdunham @Bill-Becker