Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct LCC when soc is added to objective #342

Open
adfarth opened this issue Dec 19, 2023 · 0 comments · Fixed by #345
Open

Correct LCC when soc is added to objective #342

adfarth opened this issue Dec 19, 2023 · 0 comments · Fixed by #345
Assignees
Labels
bug Something isn't working

Comments

@adfarth
Copy link
Collaborator

adfarth commented Dec 19, 2023

When Settings.add_soc_incentive = true (which is the default behavior), the reported Financial.lcc includes the SOC incentive and therefore does not equal the sum of the constituent LCC components.

This is likely happening here:

if !(isempty(p.s.storage.types.elec)) && p.s.settings.add_soc_incentive

We need to correct the reported LCC to remove this soc incentive component

@adfarth adfarth added the bug Something isn't working label Dec 19, 2023
@adfarth adfarth self-assigned this Dec 19, 2023
@adfarth adfarth linked a pull request Jan 3, 2024 that will close this issue
@adfarth adfarth linked a pull request Jan 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
1 participant