Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle incomplete EPW design conditions header #5134

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
+10,060 −1,001
Open

Handle incomplete EPW design conditions header #5134

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
875e348
Add test epw with incomplete design header row.
joseph-robertson Apr 1, 2024
90e52be
Add epwfile test for incomplete design conditions.
joseph-robertson Apr 1, 2024
df1f9fc
Complete the new test for demonstrating missing fields return zero.
joseph-robertson Jul 25, 2024
8853cd9
Try changing heatingDryBulb99 to boost::optional.
joseph-robertson Jul 26, 2024
da4942d
Change remaining design condition methods to boost::optional.
joseph-robertson Jul 26, 2024
82ac99f
Stub out a 3_9_0 release notes md with design conditions change entry.
joseph-robertson Jul 26, 2024
2e7710e
Remove try catch in test, use a lambda to dry up code, and don't wrap…
jmarrec Oct 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions developer/doc/ReleaseNotes/OpenStudio_Release_Notes_3_9_0_TBD.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ You can also refer to the [OpenStudio SDK Python Binding Version Compatibility M
* `getHighHumidityOutdoorAirFlowRatio` (`boost::optional<double>` to `double`)
* `getControlHighIndoorHumidityBasedOnOutdoorHumidityRatio` (`boost::optional<bool>` to `bool`)

* [#5134](https://github.com/NREL/OpenStudio/pull/5134) - Addresses #5132, EPW design condition methods should return boost::optional doubles or integers
* `EpwDesignCondition` has many API-breaking changes related to its getters. The previous behavior was to misleadingly return a value of 0 for any empty design condition header field. The types for the getters are now either boost::optional<double> or boost::optional<int>.

## Minor changes and bug fixes

Refer to the changelog on the release page at [v3.9.0](https://github.com/NREL/OpenStudio/releases/v3.9.0)
Expand Down
1 change: 1 addition & 0 deletions resources/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ set(utilities_resources_src
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3-leapday.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3-noleapday.epw
utilities/Filetypes/USA_CO_Golden-NREL.724666_TMY3_IncompleteDesign.epw
utilities/Filetypes/USA_CO_Golden-NREL.wrap.epw
utilities/Filetypes/USA_CO_Golden-NREL.amy
utilities/Filetypes/USA_CO_Golden-NREL.wrap.amy
Expand Down
Loading
Loading