Skip to content

Commit

Permalink
Fixing swig bindings for @nmerket
Browse files Browse the repository at this point in the history
  • Loading branch information
macumber committed Feb 9, 2017
1 parent bcc4772 commit fcf99c0
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions openstudiocore/src/model/ModelSimulation.i
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,17 @@

#endif

namespace openstudio {
namespace model {

// forward declarations
class Surface;
class SubSurface;
class InternalMass;
class Schedule;
}
}

UNIQUEMODELOBJECT_TEMPLATES(SimulationControl);
UNIQUEMODELOBJECT_TEMPLATES(LightingSimulationControl);
UNIQUEMODELOBJECT_TEMPLATES(SizingParameters);
Expand Down

8 comments on commit fcf99c0

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (macumber) - x86_64-MacOS-10.10-clang: Build Failed

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-MacOS-10.10-clang: Build Failed

Build Badge Test Badge

@nmerket
Copy link
Member

@nmerket nmerket commented on fcf99c0 Feb 10, 2017 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macumber
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, general issue is that if swig encounters a type it does not know about it will generate some default code. if you forward declare the type then swig will know to handle it correctly. since this file is processed by swig before the one that defines surfaces, we just have to forward declare surface to let swig know it is coming up

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-Linux-Ubuntu-14.04-clang-3.5: Build Failed

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - x86_64-Linux-Ubuntu-14.04-cppcheck-1.61: Build Failed

Build Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - i386-Windows-7-VisualStudio-12: Tests Failed (0 of 0 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iteration (macumber) - Win64-Windows-7-VisualStudio-12: OK (2144 of 2186 tests passed, 0 test warnings)

Build Badge Test Badge

Please sign in to comment.