Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up simulations using HPXML Zones/Spaces #1881

Merged
merged 3 commits into from
Nov 13, 2024
Merged

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Nov 12, 2024

Pull Request Description

Ensure that surfaces are still collapsed when HPXML Zones/Spaces are provided. This speeds up the simulations. Closes #1870.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@shorowit shorowit self-assigned this Nov 12, 2024
@shorowit shorowit marked this pull request as ready for review November 13, 2024 00:14
@shorowit shorowit merged commit d38fa18 into master Nov 13, 2024
@shorowit shorowit deleted the collapse_with_zones branch November 13, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Check whether surfaces are collapsed when attached to different zones
1 participant