More ruby documentation #1784
Merged
More ruby documentation #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
reviewed
Jul 24, 2024
joseph-robertson
commented
Aug 1, 2024
Comment on lines
+83
to
+85
| ### `<enduse>_event_duration_probability.csv` | ||
|
|
||
| TODO |
There was a problem hiding this comment.
This was missing in the README; we'll need to get this TODO filled in.
shorowit
reviewed
Aug 6, 2024
shorowit
reviewed
Aug 6, 2024
There was a problem hiding this comment.
Should we revisit/reconsider having different monthly multipliers here?
There was a problem hiding this comment.
(This file renamed to schedules.csv.)
joseph-robertson
commented
Aug 6, 2024
Comment on lines
+2
to
+6
| lighting_interior,LightingInteriorMonthlyMultipliers,"1.075, 1.064951905, 1.0375, 1.0, 0.9625, 0.935048095, 0.925, 0.935048095, 0.9625, 1.0, 1.0375, 1.064951905", | ||
| dishwasher,HotWaterDishwasherMonthlyMultiplier,"1.083, 1.056, 1.023, 0.999, 0.975, 0.944, 0.918, 0.928, 0.938, 0.984, 1.059, 1.094", | ||
| clothes_washer,HotWaterClothesWasherMonthlyMultiplier,"0.968, 1.013, 0.99, 1.034, 1.019, 1.015, 1.048, 1, 1.021, 0.949, 0.945, 0.999", | ||
| clothes_dryer,ClothesDryerMonthlyMultiplier,"1.09, 1.054, 1.044, 0.996, 0.992, 0.967, 0.931, 0.906, 0.923, 0.955, 1.035, 1.108", | ||
| cooking_range,CookingMonthlyMultiplier,"1.038, 1.026, 0.976, 0.945, 0.965, 0.947, 0.939, 0.965, 0.967, 1.006, 1.098, 1.129", |
There was a problem hiding this comment.
Can we get these data sources filled in?
There was a problem hiding this comment.
Perhaps some clues in this file? https://github.com/NREL/OpenStudio-HPXML/blob/ruby-docs/BuildResidentialScheduleFile/resources/README.md
joseph-robertson
commented
Aug 6, 2024
Comment on lines
+102
to
+111
| #### Plug Loads | ||
|
|
||
| This is the baseline schedule for misc plugload, lighting and ceiling fan. | ||
| It will be modified based on occupancy. | ||
| Television plugload uses the same schedule as misc plugload. | ||
|
|
||
| #### Lighting | ||
|
|
||
| Indoor lighting schedule is generated on the fly. | ||
| Garage lighting uses the same schedule as indoor lighting. |
There was a problem hiding this comment.
Revisit whether this is still true?
shorowit
reviewed
Aug 16, 2024
shorowit
reviewed
Aug 16, 2024
shorowit
reviewed
Aug 16, 2024
shorowit
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Looks good. Thanks, @joseph-robertson! Will merge when the CI comes back green.
This was referenced Aug 22, 2024
46 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Addresses #1759 (pv.rb, battery.rb, generator.rb, location.rb).
Also moves default schedule data from
HPXMLtoOpenStudio/resources/schedules.rbtoHPXMLtoOpenStudio/resources/data/default_schedules.csv. Thehpxml_defaults.rbfile then parses (once) this data file for defaulting weekday/weekend fractions and monthly multipliers. The docs also reference this file instead of hardcoding/duplicating weekday/weekend fractions and monthly multipliers (a new helper script is created for facilitating this).Also moves schedules from
BuildResidentialScheduleFile/resources/constants.rbtoBuildResidentialScheduleFile/resources/schedules.csv. Theschedules.rbfile then parses (once) this data file for using fractions and monthly multipliers. TheREADME.mdfile is updated with the information contained inschedules_config.md.Checklist
Not all may apply:
Schematron validator (EPvalidator.xml) has been updatedSample files have been added/updated (openstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run