-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support MF space types when building has no HVAC #1615
Conversation
…udio-HPXML into other-heated-space-hvac-none
@shorowit Can you think of other updates/tests I should make here? |
I don't think it needs more tests, it's such an edge case. Have you run your test file and made sure the hourly temperatures look right? Please also update the docs to says "min of heating setpoint" instead of "min of 68F". |
I ran the new sample file with
|
Pull Request Description
Closes #1614.
Add
base-bldgtype-mf-unit-adjacent-to-multiple-hvac-none.xml
.Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
Schematron validator (EPvalidator.xml
) has been updatedopenstudio tasks.rb update_hpxmls
)Tests have been added/updated (e.g.,HPXMLtoOpenStudio/tests/test*.rb
and/orworkflow/tests/test*.rb
)openstudio tasks.rb update_measures
has been run