Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support MF space types when building has no HVAC #1615

Merged
merged 17 commits into from
Feb 22, 2024

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Feb 15, 2024

Pull Request Description

Closes #1614.
Add base-bldgtype-mf-unit-adjacent-to-multiple-hvac-none.xml.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

HPXMLtoOpenStudio/measure.rb Outdated Show resolved Hide resolved
workflow/hpxml_inputs.json Outdated Show resolved Hide resolved
HPXMLtoOpenStudio/measure.rb Outdated Show resolved Hide resolved
@shorowit shorowit changed the title Support LocationOtherHeatedSpace w/out HVAC Support MF space types when building has no HVAC Feb 21, 2024
@joseph-robertson joseph-robertson marked this pull request as ready for review February 21, 2024 22:11
@joseph-robertson
Copy link
Collaborator Author

@shorowit Can you think of other updates/tests I should make here?

@shorowit
Copy link
Contributor

I don't think it needs more tests, it's such an edge case. Have you run your test file and made sure the hourly temperatures look right?

Please also update the docs to says "min of heating setpoint" instead of "min of 68F".

@joseph-robertson
Copy link
Collaborator Author

I ran the new sample file with --hourly ALL and summarized the "Temperature: xxx" and "Weather: Drybulb Temperature" columns:

  Temperature: Conditioned Space Temperature: Other Heated Space Temperature: Other Multifamily Buffer Space Temperature: Other Non-freezing Space Weather: Drybulb Temperature
Min 51.44 68 50 40 -2.92
Max 96.819 88.5 88.5 104 104
Average 72.00614658 69.81826598 62.64732534 55.03484703 51.57561644

@shorowit shorowit merged commit 66a3859 into master Feb 22, 2024
@shorowit shorowit deleted the other-heated-space-hvac-none branch February 22, 2024 04:18
@joseph-robertson joseph-robertson mentioned this pull request Feb 22, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get_space_temperature_schedule fails when no heating and cooling
3 participants