-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
120 v hpwh #1534
base: unmet_wh_loads
Are you sure you want to change the base?
120 v hpwh #1534
Conversation
Not urgent but... how do we want to denote 120 V HPWHs in hpxml? I can think of a couple of options:
Definitely think extension elements are the way to go for "shared" vs. "dedicated" circuit versions of the product since that's a manufacturer specific thing. Rheem offers two different power levels for their HPWH, but AFAIK AO Smith has not followed suit. The AO Smith 120 V HPWH just hit the market about a month ago, so we don't have all the data to model that yet. |
… into shower energy calc)
Thought this might be of interest: we've done a small scale ResStock test run for the dedicated circuit version, looking at our sizing routine and where you do and don't run out of hot water: <style> </style>
Next up is trying to wrap up #1502, especially around how we handle multiple WHs (including handling solar correctly). I'm also working on the performance map/controls inputs for the shared circuit version, which uses a different HP and therefore a different performance map. |
Propose new HPXML elements for 120 V, dedicated vs shared? 120 V could apply to other appliances too (e.g., clothes dryers). |
Pull Request Description
Add 120V HPWH parameters into the model. We'll eventually want a "shared" and "dedicated" circuit HPWH model, so two different sets of parameters when it's a 120 V HPWH.
Based on unmet_wh_loads PR
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml
) has been updatedtasks.rb
)HPXMLtoOpenStudio/tests
and/orworkflow/tests/hpxml_translator_test.rb
)openstudio tasks.rb update_measures
has been run