Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi-climate HERS tests #656

Draft
wants to merge 28 commits into
base: master
Choose a base branch
from
Draft

Add multi-climate HERS tests #656

wants to merge 28 commits into from

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Nov 22, 2022

Pull Request Description

Adds multi-climate HERS tests from proposed Pub 002 draft.

TODO:

  • Add 10 - Ducts in Attic case
  • Add 13 - Heat Pump case
  • Review HPXMLs relative to final publication

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@shorowit shorowit self-assigned this Nov 22, 2022
@bpark1327
Copy link
Collaborator

bpark1327 commented Apr 9, 2024

@shorowit I have some questions/comments for you:

  • For the NoMechVentDuctsInAttic scenario, the ducts have been relocated to the vented attic, but the DuctLeakageMeasurement remains unchanged. Is this intentional? [Scott response: Neal confirmed it's intentional.]
  • Shouldn't basement wall insulation be placed on the interior side rather than the exterior side, as described in Table 4-19 where it specifies R-values for Basement Wall Continuous Interior Insulation? [Scott response: Agreed, I will change that.]
  • Should the CFIS fan power be modeled as 487.2W instead of its current value of 232W as described in section 4.7.1.8? [Scott response: Agreed, looks like they changed it.]
  • In cases with conditioned basements, there's an additional 10-foot hot water piping. Is this intentional? [Scott response: Yes, that is the standard piping length per ANSI 301. See here.]
  • For the CFISDuctsInAttic scenario, shouldn't the CFIS fan power and DuctLeakageMeasurement be fixed as described in sections 4.7.1.8 and 4.7.1.10? [Scott response: Yes, the CFIS fan power needs to be updated, but the ducts don't need to be changed (see answer to first item above).]
  • What is the correct U-factor for the reference windows in CZ1A, 1.2 or 1.3? [Scott response: Good catch, probably a typo. Should be 1.2.]
  • HPXMLs were generated based on the REM files created by Big Ladder. I reviewed the REM files. It appears that the carpet in the floor construction is modeled as R-1.23. Pub 002 specifies the use of R-2 for carpet.
  • In the REM files, the tile is modeled as R-0.05, but Pub002 specifies the use of R-0.1 for tile.

@shorowit shorowit changed the base branch from master to latest-os-hpxml October 8, 2024 17:58
Base automatically changed from latest-os-hpxml to master October 31, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants