Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Super high COP in VRFFluidTCtrl model #10752

Open
wants to merge 17 commits into
base: develop
Choose a base branch
from
Open

fix Super high COP in VRFFluidTCtrl model #10752

wants to merge 17 commits into from

Commits on Sep 19, 2024

  1. fix TotalHeatingCapacity, it missed cycling ratio

    Yujie Xu committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    e4dcfb7 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Consider cycling in defrost power

    Yujie Xu committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    6c9b079 View commit details
    Browse the repository at this point in the history
  2. 4 Configuration menu
    Copy the full SHA
    5556102 View commit details
    Browse the repository at this point in the history
  3. 2 Configuration menu
    Copy the full SHA
    d08b956 View commit details
    Browse the repository at this point in the history
  4. move defrost RTF adjust out of the if block

    so that when the outdoor conditions cause a non-zero defrost power, AND the
    system if off, defrost power would be set to zero.
    Yujie Xu committed Sep 20, 2024
    4 Configuration menu
    Copy the full SHA
    61760ed View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2024

  1. 4 Configuration menu
    Copy the full SHA
    1828d18 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Fix min pressure lower bound

    Pdischarge is the compressor discharge pressure,
    this->CompMaxDeltaP is the maximum compressor pressure rise
    Pdischarge - this->CompMaxDeltaP is minimum compressor suction pressure
    
    RefMinPe is minimum refrigerant evaporating pressure
    
    These two terms are both lower bounds of the suction pressure
    
    CapMinPe should be no less than both of them, so CapMinPe should be max of the
    two LB, not min
    Yujie Xu committed Sep 24, 2024
    4 Configuration menu
    Copy the full SHA
    3c62414 View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2024

  1. 4 Configuration menu
    Copy the full SHA
    335cf0f View commit details
    Browse the repository at this point in the history
  2. resolve err counter integer overflow

    the error message counter is a sum of all previous counter values
    it overflows to negative
    non-recurring warning keeps showing up after the overflow
    use the counter, not the sum of counter in the predicate
    Yujie Xu committed Sep 25, 2024
    4 Configuration menu
    Copy the full SHA
    54be7dc View commit details
    Browse the repository at this point in the history
  3. 4 Configuration menu
    Copy the full SHA
    0d49054 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2024

  1. clang-format

    Yujie Xu committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    d5f8c45 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2024

  1. 4 Configuration menu
    Copy the full SHA
    55c51df View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. 4 Configuration menu
    Copy the full SHA
    aba83c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Cycling ratio need to be applied inside VRFOU_CalcCompH

    because the demand is roughly Q_evap_req = TU_load + Pipe_Q - Ncomp (multiplied
    by an adjustment factor C_cap_operation). Ncomp is an input-ouptut variable of
    the function. Previously Cycling ratio is multiplied outside of VRFOU_CalcCompH
    after the function has computed Ncomp. However, this will lead to very small
    cycling ratio non-compatible with the demand as the demand is underestimated
    because of the Ncomp (in reality it should not be this large, it should be
    Ncomp * CyclingRatio). This doesn't matter on the cooling side as Ncomp is not
    involved in the demand calculation there.
    Yujie Xu committed Oct 18, 2024
    4 Configuration menu
    Copy the full SHA
    0dfe6b5 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. remove C_cap_operation in demand calculation in cyclingRatio

    remove C_cap_operation in demand calculation
    Yujie Xu committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    0554057 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4e05f26 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. fix unit test

    Yujie Xu committed Oct 25, 2024
    4 Configuration menu
    Copy the full SHA
    a39086f View commit details
    Browse the repository at this point in the history