Fix Issue #10286 window material shade mis-alignment for Output:Constructions

[jcyuan2020]

Pull request overview

• Fixes WindowMaterial:Shade eio output write-out CSV format typo #10286
• Quick fix to the eio WindowMaterial:Shade header and data mis-alignment:

Before:

After:

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• If changes fix a defect, the fix should be demonstrated in plots and descriptions
• If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• If structural output changes, add to output rules file and add OutputChange label
• If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• Perform a Code Review on GitHub
• If branch is behind develop, merge develop and build locally to check for side effects of the merge
• If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• If feature, test running new feature, try creative ways to break it
• CI status: all green or justified
• Check that performance is not impacted (CI Linux results include performance check)
• Run Unit Test(s) locally
• Check any new function arguments for performance impacts
• Verify IDF naming conventions and styles, memos and notes and defaults
• If new idf included, locally check the err file and other outputs

[nrel-bot]

@jcyuan2020 @Myoldmopar it has been 28 days since this pull request was last updated.

[mjwitte]

This works as advertised. The shift can also be seen in the Initialization Summary table report.

Before:

After:

I've added an entry to the Output Rules file and will push up shortly.

Thanks @jcyuan2020

[mjwitte]

Diffs are as expected. eio and table diffs in several files. This is ready to merge.

[Myoldmopar]

The test failure there was purely because this is coming from a fork and there is still an issue with PRs from forks that have regressions. I need to resolve a conflict on here anyway, so maybe I'll take a look at that again before pushing up the resolved branch.

[Myoldmopar]

OK, so that didn't work. This is a real challenge with the security in place. I'm not complaining, just trying to work through it. I definitely don't want to let external fork PRs slip regressions in, so without a comment ability, I think I need to have the regression workflow. A little more gracefully would be good though. I'll try one more tweak.

[Myoldmopar]

OK, this might be a nice intermediate fix.

• For PRs from branches inside this repo, it behaves like normal and reports the regressions right on the PR page
• For PRs from forked repos, it skips that step since the action won't have write access to emit a comment here. Instead it will fail with a decently formatted message explaining that there were regressions, and hinting the reviewer to the job summary page.

If this behaves alright, we'll get this merged in. Sorry to hold up this fix while I worked out the GHA issue, but it was convenient to do this on an existing fork+diffs PR.