Revert "Adopt the Extended Heat Index calculation in zone resilience"

[Myoldmopar]

The develop branch hit a pretty severe runtime slow down, and it appears it was because of this. I'm opening this PR to confirm and then we'll decide what to do. FYI @yujiex

[Myoldmopar]

Yep, check here: https://myoldmopar.github.io/EnergyPlusBuildResults/EnergyPlus-a0f92d6fdf8a9666076dee4c916113d42225b6d0-x86_64-Linux-Ubuntu-22.04-gcc-11.4.html#performance

This is indeed causing the big slow down. @yujiex if you want to come up with a very quick way to fix the HI code so that it doesn't cause any slowdown, you can, but I'm likely to merge this to get a clean baseline again.

[github-actions]

⚠️ Regressions detected on macos-14 for commit bf35cb8

Regression Summary

• ESO Big Diffs: 4
• Table Big Diffs: 3

• View Results
• Download Regressions

[Myoldmopar]

OK, I'm just going to merge this in. @yujiex we can chat about strategies to get the code back in place to go in after release. Again, if you want to find a way to get it in very quickly (today?) in a way that doesn't slow down our tests, I'm open to it. But I want to get develop's performance cleaned back up.

[yujiex]

I will attempt to fix it today @Myoldmopar

[yujiex]

@Myoldmopar. I've tried changing the root finder to the following. The unit tests still passes. So it seems this doesn't affect the result much but limit the number of iterations to 5 (or according to user input for the HVACSystemRootFindingAlgorithm. Do you feel this could resolve the problem?

state.dataRootFinder->HVACSystemRootFinding.HVACSystemRootSolver = HVACSystemRootSolverAlgorithm::BisectionThenRegulaFalsi;

[Myoldmopar]

You are welcome to push it as a new branch with those changes made and see how CI responds. If it's happy there, I'll do a quick additional test locally and if it's all clean and fast enough, it can surely drop right in.

[yujiex]

Sure. Let me push to a new branch

[rraustad]

I think you want to use RegulaFalsiThenBisection. Bisection already proved to give poor performance. You could always try both and choose the fastest option.