Partially Rebuild our CI System #10715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Myoldmopar
added
the
DoNotPublish
|
I have resolved the conflicts locally but since Decent already started, I will wait to make sure it's happy there before pushing. |
|
Everything looks great except EpJSON testing didn't make a build dir and the code integrity accidentally got disabled. I fixed those two and pushed, so this should be ready to merge right in. As it sits, this will get us Mac testing back with regressions via GHA, but still getting debug/coverage/performance/Windows on Decent CI. Given that the whole thing can't be GHA, this is at least the best of both worlds. Will merge in a bit if it's happy. |
|
All happy, merging this and 🤞 this can be pushed out of my head. It will be a snap to retry the full move to GHA after release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
OK, so testing on #10683 looked great. But after merging, it immediately started causing GHA to bog down. I considered investigating it, but decided to rapidly revert to avoid affecting others. In this PR I am more surgically addressing our CI issues. The big change here is that we are moving Mac from Decent to GHA. Which was the original intent of #10683 anyway.
This should be much much less intensive on CI, and really it's not much more than we were already doing. We are still offloading the bulk of the CI runtime to our Decent CI machines.
I'm planning on looking into setting up our Decent CI VMs as self-hosted runners so we can eliminate Decent entirely. But that can wait.