Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't catch std::exception in Debug mode so we can catch array bound errors in debugger #10678

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Don't catch std::exception in Debug mode so we can catch array bound errors in debugger #10678

merged 1 commit into from
Aug 22, 2024

Commits on Aug 21, 2024

  1. Don't catch std::exception in Debug mode so we can catch array bounds… 

    … error in debugger

cmake will properly define NDEBUG on msvc as well in release mode
cf https://gitlab.kitware.com/cmake/cmake/-/blob/1e35163a/Modules/Platform/Windows-MSVC.cmake#L481-483
    @jmarrec
    jmarrec committed Aug 21, 2024
    4 Configuration menu
    Copy the full SHA
    ce1bde5 View commit details
    Browse the repository at this point in the history