Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vertical (1-D) Solution to Earth Tube Object #10138

Merged
merged 23 commits into from
Aug 15, 2023

Commits on Apr 24, 2023

  1. NFP - initial submission

    Initial submission of the new feature proposal for the 1-D (vertical) earth tube enhancement to EnergyPlus.
    RKStrand committed Apr 24, 2023
    5 Configuration menu
    Copy the full SHA
    a745abb View commit details
    Browse the repository at this point in the history

Commits on May 11, 2023

  1. Revision (Version 2) of NFP

    Changes were made to the NFP to include the comments made during the 5/3/23 technicalities meeting regarding the assumptions made about the earth tube node and contacting an expert on earth tubes from outside the development team.
    RKStrand committed May 11, 2023
    2 Configuration menu
    Copy the full SHA
    e23014d View commit details
    Browse the repository at this point in the history

Commits on May 12, 2023

  1. Changes from Slack Convo 5/11/23

    Changes made to the NFP based on comments/conversation that took place over Slack on 5/11/23.
    RKStrand committed May 12, 2023
    2 Configuration menu
    Copy the full SHA
    32ffa7a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. 5 Configuration menu
    Copy the full SHA
    04d98dd View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2023

  1. Configuration menu
    Copy the full SHA
    7e71a22 View commit details
    Browse the repository at this point in the history
  2. 5 Configuration menu
    Copy the full SHA
    1f0dd9d View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2023

  1. Version 5 of Design Document

    Modifications as a result of last technicalities call.
    RKStrand committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    db2e651 View commit details
    Browse the repository at this point in the history
  2. 5 Configuration menu
    Copy the full SHA
    201ddea View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. 5 Configuration menu
    Copy the full SHA
    86cfaa2 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Documentation First Draft and Miscellaneous

    First drafts of the documentation in both the IO Ref and Eng Ref.  Change of a variable name to better reflect what it actually is.  Additions to the IDD.
    RKStrand committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    353170b View commit details
    Browse the repository at this point in the history
  2. 5 Configuration menu
    Copy the full SHA
    2161c77 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. intermediate commit

    this doesn't work, but i need to merge in other things
    RKStrand committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    2febfe7 View commit details
    Browse the repository at this point in the history
  2. 5 Configuration menu
    Copy the full SHA
    c299795 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Fix build and format issues

    First successful build!
    RKStrand committed Jul 29, 2023
    5 Configuration menu
    Copy the full SHA
    6699d6d View commit details
    Browse the repository at this point in the history
  2. Fix minor format issue

    Correction of minor issue
    RKStrand committed Jul 29, 2023
    5 Configuration menu
    Copy the full SHA
    d1370a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Fix input problem for blank type

    Fixed an issue with a blank solution type.  It should now interpret the input when solution type is blank correctly (default back to Basic).  There should be no diffs in the ci results (hopefully).
    RKStrand committed Jul 30, 2023
    5 Configuration menu
    Copy the full SHA
    b22afa2 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2023

  1. Fix a variety of minor issues

    Various minor issues fixed.  This now runs but the results are not correct for the vertical solution.
    RKStrand committed Aug 1, 2023
    5 Configuration menu
    Copy the full SHA
    9084340 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2023

  1. It's working, it's working!

    Working code with results that look like one would expect.  More testing and then unit tests and docs final edits to come.
    RKStrand committed Aug 4, 2023
    Configuration menu
    Copy the full SHA
    3a5796f View commit details
    Browse the repository at this point in the history
  2. 4 Configuration menu
    Copy the full SHA
    ae8bdd3 View commit details
    Browse the repository at this point in the history
  3. Unit and Regression Test

    Addition of two unit tests and a new regression test.  Minor documentation additions and tweaks.
    RKStrand committed Aug 4, 2023
    5 Configuration menu
    Copy the full SHA
    a251c56 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2023

  1. Review Comment Edits

    Modifications to address review comments.
    RKStrand committed Aug 8, 2023
    11 Configuration menu
    Copy the full SHA
    992d459 View commit details
    Browse the repository at this point in the history
  2. Fix to allocation of vectors

    Used the wrong term to size vectors.  Should fix the issues with Linux debug errors.
    RKStrand committed Aug 8, 2023
    5 Configuration menu
    Copy the full SHA
    1a7b1b2 View commit details
    Browse the repository at this point in the history

Commits on Aug 9, 2023

  1. Negative index correction

    Found a problem with one of the loops in the vertical algorithm, resulted from bad job moving stuff around.  Xcode was very forgiving, Ubuntu not so much.  This should make them both happy.
    RKStrand committed Aug 9, 2023
    5 Configuration menu
    Copy the full SHA
    a445934 View commit details
    Browse the repository at this point in the history