-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Water-to-Air Heat Pump cycling and latent degradation consistent with other coils #10043
Merged
Merged
Changes from 36 commits
Commits
Show all changes
37 commits
Select commit
Hold shift + click to select a range
cfb7739
Initial IDD changes and remove parent object data members.
nealkruis e9302f5
Implement WSHP PLF curves.
nealkruis 693db9a
Update expand objects.
nealkruis c445fb6
Strip trailing spaces.
nealkruis 8c3e0bc
Update unit tests and test files.
nealkruis 02a350c
Update additional test files.
nealkruis 741a8be
Fix more test files.
nealkruis 4023e52
Merge NREL/develop.
nealkruis 4669fc7
Merge develop.
nealkruis 91e7d53
Add latent degradation inputs to variable speed cooling coils.
nealkruis 8e6c1c9
Apply clang-format.
nealkruis 7814bc2
Fix test failures.
nealkruis 15c0d98
Rename time constant variable for consistency.
nealkruis c72c685
Fix min-fields values.
nealkruis 281e02e
Update IDF snippets in unit tests.
nealkruis cee8283
Update documentation.
nealkruis 40bec8b
Trim trailing whitespace.
nealkruis 6a70b9f
Merge remote-tracking branch 'nrel/develop' into 9966-wshp-cycling
nealkruis ad36c45
Merge develop, resolve conflicts
Myoldmopar 6f3b4b8
Add transition rules text
Myoldmopar 1965c70
Merge remote-tracking branch 'origin/develop' into 9966-wshp-cycling
Myoldmopar deb0b45
Clarify transition rules to new PLF(PLR) curve.
nealkruis 232c7c4
Further clarification to PLF(PLR) changes.
nealkruis 9cde42a
Revert accidental deletion.
nealkruis 3abd05b
Merge branch '9966-wshp-cycling' of github.com:NREL/EnergyPlus into 9…
Myoldmopar 0a1f8e4
Merge remote-tracking branch 'origin/develop' into 9966-wshp-cycling
Myoldmopar cdf2cf5
Update input transition rules [decent_ci_skip].
nealkruis 8b2a0cb
Merge branch '9966-wshp-cycling' of github.com:NREL/EnergyPlus into 9…
Myoldmopar 5023da6
Merge remote-tracking branch 'origin/develop' into 9966-wshp-cycling
Myoldmopar b68aa2c
Basic skeleton of transition; seems to be working; but needs integrat…
Myoldmopar 574da51
Remove 90.1 IO ref documentation from WAHP
Myoldmopar 3c04d64
Revert 90.1 changes from WAHP, including code, docs, tests, examples,…
Myoldmopar dc140f5
Fix failing unit tests
Myoldmopar a0aef23
One last failing unit test
Myoldmopar 16fad36
Updated transition rules
Myoldmopar c60bc45
Updated rules file descriptions
Myoldmopar e37f728
Merge develop; resolve conflicts
Myoldmopar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
182 changes: 136 additions & 46 deletions
182
doc/input-output-reference/src/overview/group-heating-and-cooling-coils.tex
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3074,40 +3074,6 @@ \subsubsection{Inputs}\label{inputs-11-023} | |
|
||
This alpha field contains the identifying name given to the WaterToAirHeatPump cooling coil, and should match the name specified in the corresponding WaterToAirHeatPump cooling coil object. | ||
|
||
\paragraph{Field: Maximum Cycling Rate}\label{field-maximum-cycling-rate-002} | ||
|
||
This numeric field contains the maximum on-off cycling rate for the compressor, which occurs at 50\% run time fraction. Suggested values are shown below (Henderson et al. 1999): | ||
|
||
\begin{figure}[htbp] | ||
\centering | ||
\includegraphics{media/image289.png} | ||
\caption{} | ||
\end{figure} | ||
|
||
\paragraph{Field: Heat Pump Time Constant}\label{field-heat-pump-time-constant-001} | ||
|
||
This numeric field contains the time constant for the cooling coil's capacity to reach steady state after startup. Suggested values are shown below (Henderson et al. 1999): | ||
|
||
\begin{figure}[htbp] | ||
\centering | ||
\includegraphics{media/image290.png} | ||
\caption{} | ||
\end{figure} | ||
|
||
\paragraph{Field: Fraction of On-Cycle Power Use}\label{field-fraction-of-on-cycle-power-use-001} | ||
|
||
This numeric field contains the fraction of on-cycle power use to adjust the part load fraction based on the off-cycle power consumption due to crankcase heaters, controls, fans, and etc. Suggested value values are below (Henderson et al. 1999): | ||
|
||
\begin{figure}[htbp] | ||
\centering | ||
\includegraphics{media/image291.png} | ||
\caption{} | ||
\end{figure} | ||
|
||
\paragraph{Field: Heat Pump Fan Delay Time}\label{field-heat-pump-fan-delay-time-001} | ||
|
||
This numeric field contains the time delay in seconds for the heat pump supply air fan to shut off after compressor cycle off. This value can be obtained from the manufacturer or the heat pump catalog. Suggested value is 60 seconds. This value is disregared at times when the WaterToAirHeatPump's fan operating mode schedule value is greater than 0 (i.e., continuous fan mode). | ||
|
||
\paragraph{Field: Supplemental Heating Coil Object Type}\label{field-supplemental-heating-coil-object-type-1-000} | ||
|
||
This is the object type of the supplemental heating coil. The hot water and steam heating coils require specifying plant loop, branches, and connector objects to support the heating coils, and are placed on the demand side of the plantloop. The hot water flow modulation through the supplemental heating coil does not require additional controller or \hyperref[controllerwatercoil]{Controller:WaterCoil} object. The parent object (Zone Water to Air Heat Pump) itself provides the ``controller'' function of modulating water flow. The valid choices are: | ||
|
@@ -3214,10 +3180,6 @@ \subsubsection{Inputs}\label{inputs-11-023} | |
Sys 1 Heat Pump Heating Mode, !- Heating Coil Name | ||
Coil:Cooling:WaterToAirHeatPump:EquationFit, !- Cooling Coil Object Type | ||
Sys 1 Heat Pump Cooling Mode, !- Cooling Coil Name | ||
2.5, !- Maximum Cycling Rate | ||
60.0, !- Heat Pump Time Constant | ||
0.01, !- Fraction of On-Cycle Power Use | ||
60, !- Heat Pump Fan Delay Time | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Docs shuffling fields around and updating sample inputs, 👍 |
||
Coil:Heating:Fuel, !- Supplemental Heating Coil Object Type | ||
Heat Pump DX Supp Heating Coil 1, !- Supplemental Heating Coil Name | ||
60.0, !- Maximum Supply Air Temperature from Supplemental Heater {C} | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall discussing this Fan Delay Time input and how it relates to the coil versus the parent. I'm not really sure where this belongs at this point so I'll assume this is correctly accounted for in these changes. I scanned through the rest of the changes and this is the only thing that stands out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rraustad, the fan delay is a strange input that is used only for the latent degradation model in these coils. I'm not sure why it's not used in other the air-to-air DX coils. Eventually it would be good to have a base coil class that all these coils inherit from that is the one and only place where the latent degradation model is implemented.