Skip to content

Commit

Permalink
Add transition rules text
Browse files Browse the repository at this point in the history
  • Loading branch information
Myoldmopar committed Jul 7, 2023
1 parent ad36c45 commit 6f3b4b8
Showing 1 changed file with 64 additions and 3 deletions.
67 changes: 64 additions & 3 deletions src/Transition/InputRulesFiles/Rules23-1-0-to-23-2-0.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,69 @@ Input Changes version 23.1.0 to 23.2.0
This file documents the structural changes on the input of EnergyPlus that could affect interfaces, etc.
This was previously an Excel workbook that made for very difficult version control, especially during busy times around code freezes.

# Object Change: OBJECT NAME HERE
# Part Load Fraction Correlation

Describe input change here
There are a few object changes below that are related to the cycling and latent degradation inputs.
Some of these require a calculation to get the new input.
The correlation being applied is:

Use links like: [PR#9480](https://github.com/NREL/EnergyPlus/pull/9480/)
(1 - Cd) + Cd * PLR

Thus calculating the new coefficient is:

Cd = A * (1 - exp(-1/A))

where:

- A = 4 * tau * (Nmax/3600)
- tau = Heat Pump Time Constant from parent or default 60s
- Nmax = Maximum Cycling Rate from parent or default 2.5/hr

# Object Change: HVACTemplate:Zone:WaterToAirHeatPump:
- "Remove N20, \field Fraction of On-Cycle Power Use"

# Object Change: AirLoopHVAC:UnitarySystem:
- Move "N19, \field Maximum Cycling Rate" to child object
- Move "N20, \field Heat Pump Time Constant" to child object
- Remove "N21, \field Fraction of On-Cycle Power Use"
- Move "N22, \field Heat Pump Fan Delay Time" to child object

# Object Change: AirLoopHVAC:UnitaryHeatPump:WaterToAir:
- Move "N4, \field Maximum Cycling Rate" to child object
- Move "N5, \field Heat Pump Time Constant" to child object
- Remove "N6, \field Fraction of On-Cycle Power Use"
- Move "N7, \field Heat Pump Fan Delay Time" to child object

# Object Change: Coil:Cooling:DX:VariableSpeed:
- Insert "N7, \field Maximum Cycling Rate" from parent or leave blank
- Insert "N8, \field Latent Capacity Time Constant" from parent's "Heat Pump Time Constant" or leave blank
- Insert "N9, \field Fan Delay Time" from parent or leave blank

# Object Change: Coil:Cooling:WaterToAirHeatPump:ParameterEstimation:
- Insert "A8, \field Part Load Fraction Correlation Curve Name" and add Curve:Linear using correlation above.
- Insert "N21, \field Maximum Cycling Rate" from parent or leave blank
- Insert "N22, \field Latent Capacity Time Constant" from parent's "Heat Pump Time Constant" or leave blank
- Insert "N23, \field Fan Delay Time" from parent or leave blank

# Object Change: Coil:Heating:WaterToAirHeatPump:ParameterEstimation:
- Insert "A8, \field Part Load Fraction Correlation Curve Name" and add Curve:Linear using correlation above.

# Object Change: Coil:Cooling:WaterToAirHeatPump:EquationFit:
- Insert "A9, \field Part Load Fraction Correlation Curve Name" and add Curve:Linear using correlation above.
- Insert "N13, \field Maximum Cycling Rate" from parent or leave blank
- Insert "N14, \field Latent Capacity Time Constant" from parent's "Heat Pump Time Constant" or leave blank
- Insert "N15, \field Fan Delay Time" from parent or leave blank

# Object Change: Coil:Heating:WaterToAirHeatPump:EquationFit:
- Insert "A8, \field Part Load Fraction Correlation Curve Name" and add Curve:Linear using correlation above.

# Object Change: Coil:Cooling:WaterToAirHeatPump:VariableSpeedEquationFit:
- Insert "N8, \field Maximum Cycling Rate" from parent or leave blank
- Insert "N9, \field Latent Capacity Time Constant" from parent's "Heat Pump Time Constant" or leave blank
- Insert "N10, \field Fan Delay Time" from parent or leave blank

# Object Change: ZoneHVAC:WaterToAirHeatPump:
- Move "N7, \field Maximum Cycling Rate" to child object
- Move "N8, \field Heat Pump Time Constant" to child object
- Remove "N9, \field Fraction of On-Cycle Power Use"
- Move "N10, \field Heat Pump Fan Delay Time" to child object

5 comments on commit 6f3b4b8

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9966-wshp-cycling (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.3: OK (3409 of 3478 tests passed, 7 test warnings)

Messages:\n

  • 7 tests had: Table small diffs.
  • 25 tests had: EIO diffs.
  • 19 tests had: ESO big diffs.
  • 14 tests had: MTR big diffs.
  • 69 tests had: Table big diffs.
  • 12 tests had: AUD diffs.
  • 15 tests had: ERR diffs.
  • 4 tests had: ESO small diffs.
  • 4 tests had: RDD diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 723
  • Failed: 69

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9966-wshp-cycling (Myoldmopar) - Win64-Windows-10-VisualStudio-16: OK (2664 of 2664 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9966-wshp-cycling (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.3-UnitTestsCoverage-Debug: OK (1891 of 1891 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9966-wshp-cycling (Myoldmopar) - x86_64-MacOS-10.17-clang-13.0.0: OK (3369 of 3437 tests passed, 7 test warnings)

Messages:\n

  • 7 tests had: Table small diffs.
  • 24 tests had: EIO diffs.
  • 18 tests had: ESO big diffs.
  • 14 tests had: MTR big diffs.
  • 68 tests had: Table big diffs.
  • 12 tests had: AUD diffs.
  • 14 tests had: ERR diffs.
  • 4 tests had: ESO small diffs.
  • 4 tests had: RDD diffs.
  • 1 test had: MTR small diffs.

Failures:\n

regression Test Summary

  • Passed: 704
  • Failed: 68

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9966-wshp-cycling (Myoldmopar) - x86_64-Linux-Ubuntu-22.04-gcc-11.3-IntegrationCoverage-Debug: OK (776 of 776 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.