Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ccaradon/hprtu debug #245

Merged
merged 24 commits into from
Oct 29, 2024

Conversation

ChristopherCaradonna
Copy link
Contributor

Pull request overview

This PR primarily addresses errors in the HP RTU measure caused by a bug in the OpenStudio FT. The errors occur when there is a mismatch between heating and cooling speeds, which is allowed in E+, but is incorrectly articulated in the FT causing failure.

The temporary fix is to create 'dummy' speed levels to ensure that the number of speeds for heating and cooling are always equal. The dummy speeds are set to match the parameters of the lowest 'real' speed. For instance, if heating has 2 speeds and cooling has 4, the heating system will be assigned 4 speeds, where the lowest 2 are duplicates of the lowest actual speed.

This workflow should be modified once the OpenStudio FT issue is resolved: NREL/OpenStudio#5277

Pull Request Author: Chris CaraDonna

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@JanghyunJK JanghyunJK merged commit 162ee39 into jk/hprtu_final_final_new_sampling Oct 29, 2024
@JanghyunJK JanghyunJK deleted the ccaradon/hprtu_debug branch October 29, 2024 14:30
@JanghyunJK JanghyunJK mentioned this pull request Oct 29, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants