μμ λ λ~π«Ά
μ€ν¬ν° νμ΄ μ±μ ν΄λ‘ μ½λ© ν Repo μ
λλ€.
μ΄λͺ
μ§ (@thingineeer) |
κΉλμ° (@Nya128) |
κΉλ―Όμ± (@mminny) |
---|---|---|
Lead, 1λ²μ§Έ λ·° (Home λ·°) 3λ²μ§Έ λ·°(λΈλ¬ μ²λ¦¬ λ·°) | 4λ²μ§Έ(Artist λ·°) 5λ²μ§Έ (Artist Chart λ·°) | 2λ²μ§Έ λ·° (Recommend λ·°) |
Commit Message Rule
[Prefix] <#IssueNumber> - <Description>
[Prefix]
[Feat] : μλ‘μ΄ κΈ°λ₯ ꡬν
[Add] : λΆμμ μΈ μ½λ μΆκ° λ° λΌμ΄λΈλ¬λ¦¬ μΆκ°, μλ‘μ΄ νμΌ μμ±
[Chore] : λ²μ μ½λ μμ , ν¨ν€μ§ ꡬ쑰 λ³κ²½, νμ
λ° λ³μλͺ
λ³κ²½ λ±μ μμ μμ
, νμΌ μ΄λ¦ λ³κ²½
[Del] : μΈλͺ¨μλ μ½λλ νμΌ μμ
[Design] : UI μμ
[Fix] : λ²κ·Έ λ° μ€λ₯ ν΄κ²°
[Refactor] : μ λ©΄ μμ
[Docs] : READMEλ WIKI λ±μ λ¬Έμ κ°μ
[Setting] : νλ‘μ νΈ μΈν
[Comment] : μ£Όμ μΆκ°, μμ (Only μ£Όμ)
ex) [Feat] #5 - μλ² μ°κ²° ꡬν
Code Review Rule
μ½λ 리뷰λ₯Ό μ΅λν 빨리 λ¬κ³ λ°μνμ! (λ₯κΈλ₯κΈ λ§ν¬λ‘ ν΄κ²°νκΈ°)
ex) μ΄κ±° μ μ΄λ κ² μ§°μ΄μ? (X)
ν΄λΉ κΈ°λ₯μ ꡬνν μ΄μ κ° κΆκΈν©λλ€
Issue Naming Rule
[Prefix] <Description>
ex) [Feat] - Spotify λΈλ¬μ²λ¦¬ ꡬν
Git Flow
- μ΄μ μμ±
- λΈλμΉ μμ±
- λΈλμΉ add, commit, push β PR κ³Όμ κ±°μΉκΈ°
- μ΅μ 1λͺ
"Approve" μμ΄μΌ merge (κ°μ λ¨Έμ§ κΈμ§ νλ©΄ μνΈ μ λͺ
bypass) - λ¨Έμ§ν ( ν΄λΉ λΈλμΉ λ°λ‘ μ κ±° )
- pull λ°μμ λ€μ μ΄μ μ§ν
Git
ν΄κ²° μ΄λ €μ΄ Confilct μκΈ°λ©΄ λͺ μ§ μκ² λ°λ‘ μ°λ½νκΈ° !!!
μΆ©λ μλκ² κ°μ νμΌ μ΅λν μμ νμ§ μκΈ°
Foldering
βββ Spotify-iOS
βΒ Β βββ Application
βΒ Β βΒ Β βββ AppDelegate.swift
βΒ Β βΒ Β βββ Base.lproj
βΒ Β βΒ Β βββ Info.plist
βΒ Β βΒ Β βββ SceneDelegate.swift
βΒ Β βΒ Β βββ ViewController.swift
βΒ Β βββ Data
βΒ Β βΒ Β βββ ArtistDTO.swift
βΒ Β βΒ Β βββ ArtistImageModel.swift
βΒ Β βΒ Β βββ ArtistPopularMusicModel.swift
βΒ Β βΒ Β βββ ArtistTabbarModel.swift
βΒ Β βΒ Β βββ HomeMockingModel.swift
βΒ Β βΒ Β βββ PlaylistsDTO.swift
βΒ Β βΒ Β βββ PopularArtistDTO.swift
βΒ Β βΒ Β βββ RecommendDTO.swift
βΒ Β βΒ Β βββ SongsDTO.swift
βΒ Β βββ Global
βΒ Β βΒ Β βββ Extension
βΒ Β βΒ Β βββ Factory
βΒ Β βΒ Β βββ Literals
βΒ Β βΒ Β βββ Resource
βΒ Β βββ Network
βΒ Β βΒ Β βββ Base
βΒ Β βΒ Β βββ Service
βΒ Β βΒ Β βββ ServiceType
βΒ Β βββ Presentation
βΒ Β βββ Cells
βΒ Β βββ Common
βΒ Β βββ TabBar
βΒ Β βββ ViewControllers
βΒ Β βββ Views