Feat/#6 week2 compose 필수과제 구현 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiledEgg-s
approved these changes
Apr 20, 2024
Comment on lines
131
to
134
| id.length !in 6..10 -> R.string.sign_up_id_error | ||
| pw.length !in 8..12 -> R.string.sign_up_pw_error | ||
| nick.isBlank() || nick.length != nick.trim().length -> R.string.sign_up_nick_error | ||
| etc.length !in 1..Int.MAX_VALUE -> R.string.sign_up_etc_error |
There was a problem hiding this comment.
이렇게 숫자를 하드코딩하는건 안좋다고 합니다!!
Companion Object에 선언해봐요~
chattymin
requested changes
Apr 20, 2024
|
|
||
|
|
||
| @Composable | ||
| fun FriendProfileItem(friend: Friend) { |
There was a problem hiding this comment.
friend를 넣어주는 것도 좋지만, 저는 각각 나눠서 넣어주는 것을 더 선호합니다.
만약 friend내부 객체가 바뀐다면?
friend가 아닌 객체도 해당 함수를 재사용하게 된다면?
ui테스트를 위해 Preview를 만들 때 객체도 생성해야 하는 불편함
이런 부분들을 생각해서 저는 image, name, description 등등.. 나눠서 넣어주는걸 선호합니다
Comment on lines
137
to
139
| putExtra("userId", id) | ||
| putExtra("userPw", pw) | ||
| putExtra("userNick", nick) |
There was a problem hiding this comment.
숫자를 Companion Object로 빼면서 이것도 빼면 좋을거 같아요~
Comment on lines
59
to
62
| fun LoginUI(userId: String?, userPw: String?, userNick: String?) { | ||
| val context = LocalContext.current | ||
| var id by remember { mutableStateOf("") } | ||
| var pw by remember { mutableStateOf("") } |
There was a problem hiding this comment.
이름이 UI이기 때문에 id와 pw도 SatateHoisting을 활용해 값을 상단으로 빼는건 어떨까요??
LoginUI에는 UI와 관련된 부분만 존재하고, 값을 수정하거나 클릭했을때의 액션은 밖으로 빼는게 좋아 보입니다!
youjin09222
reviewed
Apr 21, 2024
Comment on lines
70
to
80
| Text( | ||
| text = "ID", | ||
| fontSize = 20.sp) | ||
| fontSize = 20.sp | ||
| ) | ||
| TextField( | ||
| value = id, | ||
| label = { Text(stringResource(R.string.tf_label_id)) }, | ||
| onValueChange = { id = it }, | ||
| placeholder = {Text(stringResource(R.string.tf_ph_id))}, | ||
| singleLine = true | ||
| ) | ||
| Spacer(modifier = Modifier.height(50.dp),) | ||
| value = id, | ||
| label = { Text(stringResource(R.string.tf_label_id)) }, | ||
| onValueChange = { id = it }, | ||
| placeholder = { Text(stringResource(R.string.tf_ph_id)) }, | ||
| singleLine = true | ||
| ) |
chattymin
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
KakaoTalk_20240419_013037282.mp4
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
그래도...1주차때보다는 0.0001%정도 더 컴포즈랑 가까워진것같아요....
제 코드 ... 부족한 점 많지만 리뷰달아주시면 열심히 반영하겠습니다!!!
코리 반영하기