Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#14 week6 xml #15

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Feat/#14 week6 xml #15

merged 2 commits into from
Jun 7, 2024

Conversation

hyeeum
Copy link
Collaborator

@hyeeum hyeeum commented May 24, 2024 •
edited
Loading

πŸ“Œπ˜π˜΄π˜΄π˜Άπ˜¦π˜΄

πŸ“Žπ˜žπ˜°π˜³π˜¬ π˜‹π˜¦π˜΄π˜€π˜³π˜ͺ𝘱𝘡π˜ͺ𝘰𝘯

πŸ“·π˜šπ˜€π˜³π˜¦π˜¦π˜―π˜΄π˜©π˜°π˜΅

πŸ’¬π˜›π˜° π˜™π˜¦π˜·π˜ͺ𝘦𝘸𝘦𝘳𝘴

6μ£Όμ°¨ κ³Όμ œμ— μžˆλŠ” λ‚΄μš©μ€ 적용된 μƒνƒœλΌμ„œ pr μ˜¬λ ΈμŠ΅λ‹ˆλ‹€!
6μ£Όμ°¨λ•Œ 배운 λ‚΄μš© 적용 ν›„ 컀밋 μ–Όλ₯Έ μ˜¬λ¦¬κ² μŠ΅λ‹ˆλ‹·!

코리 λ°˜μ˜ν•˜κΈ°

chattymin
chattymin approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

week4μ—μ„œ 거의 κ°™κ²Œ κ°€μ Έμ˜¨ μ½”λ“œκ°™λ„€μš”!!
μˆ˜κ³ ν•˜μ…¨κ΅¬ 7μ£Όμ°¨ 과제 ν™”μ΄νŒ…μž…λ‹ˆλ‹€ :)

chattymin
chattymin requested changes May 28, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ–΄ λ‹€μ‹œλ³΄λ‹ˆκΉŒ 이거 main-xml둜 ν•©μΉ˜κ³  μžˆμ–΄μš”!!!
develop-xml둜 λ¨Έμ§€ν•΄μ•Όν•©λ‹ˆλ‹€!! 이건 PR λ‹«μ•„μ£Όμ„Έμš”

@hyeeum hyeeum changed the base branch from main-xml to develop-xml May 29, 2024 11:43
@hyeeum
Copy link
Collaborator Author

hyeeum commented May 29, 2024

μ œκ°€ 정신이 μ—†μ–΄μ„œ.. 이런 μ‹€μˆ˜λ₯Ό ν•΄λ²„λ Έλ„€μš”.. 방금 baseλ₯Ό λ°”κΏ¨λŠ”λ° 이거둜 ν•΄κ²°λ κΉŒμš”??

@hyeeum hyeeum self-assigned this May 29, 2024
chattymin
chattymin approved these changes May 29, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

였 λŒ€λ°• baseλ₯Ό λ°”κΏ€ 수 μžˆκ΅°μš”?!!?!?!!?
γ…‹γ…‹γ…‹γ…‹γ…‹γ…‹γ…‹ κ΅Ώμž…λ‹ˆλ‹€~

youjin09222
youjin09222 approved these changes May 29, 2024
View reviewed changes
Copy link

@youjin09222 youjin09222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘πŸ‘

boiledEgg-s
boiledEgg-s approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@boiledEgg-s boiledEgg-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ’£

@hyeeum hyeeum merged commit 0ca2bd4 into develop-xml Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boiledEgg-s boiledEgg-s boiledEgg-s approved these changes

@youjin09222 youjin09222 youjin09222 approved these changes

@chattymin chattymin chattymin approved these changes

Assignees

@hyeeum hyeeum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hyeeum @chattymin @youjin09222 @boiledEgg-s