Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VIIRS DA capability for the vector formatted land-only DA workflow #23

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

yuanxue2870
Copy link
Contributor

Describe your changes (READY FOR REVIEW/DO NOT MERGE)

Summarise all code changes included in PR:

  1. added the VIIRS DA capability;
  2. conducted a bugfix for varying WINLEN in the yaml files.
    Note: VIIRS ioda converters are likely being merged with IMS at a later date. For now, in this PR, IMS and VIIRS have their own ioda converter individually.  

List any associated PRs in the submodules.

  1. Add VIIRS SCF processing capability and merge with current IMS_proc land-SCF_proc#7

Issue ticket number and link

List the git Issue that this PR addresses:

  1. Add VIIRS DA capability in the original (vector formatted) land-only DA workflow #21
  2. Bug fix: reflect WINLEN for DA window length in the yaml files #22

Test output

Is this PR expected to pass the DA_IMS_test (ie., does it change the output)?
Yes. No changes to the output.

Does it pass the DA_IMS_test?
Yes.

If changes to the test results are expected, what are these changes? Provide a link to the output directory when running the test:
N/A.

Checklist before requesting a review

  • My branch being merged is up to date with the latest develop.
  • I have performed a self-review of my code by examining the differences that will be merged.
  • I have not made any unnecessary code changes / changed any default behavior.
  • My code passes the DA_IMS_test, or differences can be explained.

@yuanxue2870
Copy link
Contributor Author

Please review: @ClaraDraper-NOAA, @YoulongXia-NOAA, @tsga

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant