data_override_init: Initialize both r4 and r8 modes by default #1638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 27, 2025 11:23
If `data_override_init` is called with no `mode` argument, initialize both the r4_kind and r8_kind versions of the module by default.
Replace all occurrences of `if (iand(___, r4_kind))` with `if (iand(___, r4_kind).eq.r4_kind)`
uramirez8707
requested changes
Jan 30, 2025
|
|
||
| if (present(mode)) then | ||
| mode_selector = mode | ||
| if (mode.eq.r4_kind .or. mode.eq.r8_kind) then | ||
| mode_flags = mode |
There was a problem hiding this comment.
What if I call data_override twice, once with the mode as r4_kind and another time as r8_kind? I think this model_flags will be overridden. Does this matter?
There was a problem hiding this comment.
Yes, that's correct. Lines 146-149 should update atm_mode, etc. using bitwise or rather than just assign mode_flags as the value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If
data_override_initis called with nomodeargument, initialize both the r4_kind and r8_kind versions of the module by default.How Has This Been Tested?
Github CI
Checklist:
make distcheckpasses