Config and mapping files for ADPUPA prepBUFR #17
Conversation
PraveenKumar-NOAA
requested review from
emilyhcliu,
nicholasesposito,
BrettHoover-NOAA and
xincjin-NOAA
dump/mapping/bufr_adpupa_prepbufr.py
Outdated
| #!/usr/bin/env python3 | ||
| import os | ||
| import sys | ||
| sys.path.append('/scratch1/NCEPDEV/da/Praveen.Singh/HERA/bufr-query/build/lib') |
There was a problem hiding this comment.
Get rid of these sys.path.append lines.
There was a problem hiding this comment.
@nicholasesposito thanks, removed these lines.
dump/mapping/bufr_adpupa_prepbufr.py
Outdated
| log_method(message) | ||
|
|
||
|
|
||
| #def Compute_dateTime(cycleTimeSinceEpoch, hrdr): |
There was a problem hiding this comment.
dateTime should stay in. For the regular mapping yaml, @emilyhcliu and I discussed and said that DHR should determine dateTime if the script is not being used, BUT the script is being used, dateTime should be computed using the script.
There was a problem hiding this comment.
@nicholasesposito added a Python subroutine to compute dateTime in the Python script.
| if update: | ||
| # Define the variables to be added in a list of dictionaries | ||
| variables = [ | ||
| #{ |
| logging(comm, 'DEBUG', f'Do ps ObsError calculations') | ||
| poe = container.get('variables/pressureError') | ||
| psoe = np.full(poe.shape[0], poe.fill_value) | ||
| psoe = np.where(cat == 0, poe, psoe) |
There was a problem hiding this comment.
Is it possible to define these (and the corresponding container.replace) as a method? There so many repeat codes here.
| logger = Logger('bufr_adpupa_prepbufr.py', level=log_level, colored_log=False) | ||
|
|
||
|
|
||
| def logging(comm, level, message): |
There was a problem hiding this comment.
Should we put this method into a util file and import it from the util file? I guess we need to use it many times.
There was a problem hiding this comment.
It's been lightly discussed but I don't think we fully decided to do this, though it may make sense.
…, hrdr) subroutine
This PR adds following config/ and mapping/ files for the ADPUPA prepBUFR:
All of the four jobs (bufr2netcdf, script2netcdf, bufr_backend, script_backend) were run and tested using serial and parallel execution with nproc=2.