Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add components for surface snow data #14

Merged
merged 11 commits into from
Jan 14, 2025
Merged

add components for surface snow data #14

merged 11 commits into from
Jan 14, 2025

Conversation

emilyhcliu
Copy link
Collaborator

@emilyhcliu emilyhcliu commented Dec 8, 2024

This PR includes the following changes:

  1. Add mapping and Python for surface snow data
  2. Move test configuration from /spoc/dump/config to /spoc/ush/test
  3. Remove an old test configuration file
  4. Update README for test (/spoc/ush/test)
  5. Change filename convention change from bufr2ioda to bufr (more general)
  6. Fix Python coding norm errors (ctest is adding to obsForge - in progress obsForge PR #4

dump/mapping/bufr_sfcsno.py Show resolved Hide resolved
dump/mapping/bufr_sfcsno.py Show resolved Hide resolved
ush/test/README.md Outdated Show resolved Hide resolved
ush/test/README.md Show resolved Hide resolved
ush/test/config/bufr_bufr_backend_sfcsno.yaml Outdated Show resolved Hide resolved
Copy link

@PraveenKumar-NOAA PraveenKumar-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

dump/mapping/bufr_sfcsno_mapping.yaml Show resolved Hide resolved
dump/mapping/bufr_sfcsno_mapping.yaml Outdated Show resolved Hide resolved
rmclaren
rmclaren previously approved these changes Dec 13, 2024
@emilyhcliu emilyhcliu dismissed stale reviews from rmclaren and PraveenKumar-NOAA via bd3bc8c January 14, 2025 08:13
@emilyhcliu
Copy link
Collaborator Author

emilyhcliu commented Jan 14, 2025

@PraveenKumar-NOAA @nicholasesposito @rmclaren
I updated the scripts/yamls, and readme documentation based on your review comments:

  • changed totalSnowDepth unit from mm to m following IODA data convention
  • added unit m to stationEvelation
  • the unit for stationIdentification is set to Index for now since there is no unit defined in IODA data convention for stationIdentification.
  • added `bound to include:begin" for time window in the test configuration YAMLs
  • updated README file for testing

I also updated the following:

  • added observation receipt time (dataReceiptTime) to YAML for snow and satwind data
  • updated test reference files (uploaded to EMCRZDM)

Please review them one more time and approve these updates if they look good to you.

There will be no more updates from me for this PR. I will merge the PR as soon as I get your approvals. Thanks!

Copy link

@nicholasesposito nicholasesposito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good to me!

@emilyhcliu emilyhcliu merged commit 4d77e45 into develop Jan 14, 2025
@emilyhcliu emilyhcliu deleted the feature/sfcsno branch January 14, 2025 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants