Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-sci] Folds in local change made to fix missing subdomain files in retro #575

Merged
merged 1 commit into from
Dec 8, 2024
Merged

[dev-sci] Folds in local change made to fix missing subdomain files in retro #575

merged 1 commit into from
Dec 8, 2024

Conversation

MatthewPyle-NOAA
Copy link
Contributor

Fix was previously made in "main".

DESCRIPTION OF CHANGES:

  • Removes a "&" within poe-script generation. WCOSS update made things stricter, and we don't want detached processes with a poe-script.

TESTS CONDUCTED:

Machines/Platforms:

  • WCOSS2
    • Cactus/Dogwood
    • Acorn
  • RDHPCS
    • Hera
    • Jet
    • Orion
    • Hercules

Test cases:

  • Engineering tests
    • Non-DA engineering test
    • DA engineering test
      • Retro
      • Ensemble
      • Parallel
  • RRFS fire weather
  • RRFS_A:
  • RRFS_B:
  • RTMA:
  • Others: v1.1.2 retro system has been running with this fix.

ISSUE:

CONTRIBUTORS (optional):

@MatthewPyle-NOAA MatthewPyle-NOAA merged commit 6ca9271 into NOAA-EMC:dev-sci Dec 8, 2024
1 check passed
@MatthewPyle-NOAA MatthewPyle-NOAA deleted the feature/prdgenfix branch December 8, 2024 17:50
@MatthewPyle-NOAA MatthewPyle-NOAA mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShunLiu-NOAA ShunLiu-NOAA ShunLiu-NOAA approved these changes

@JacobCarley-NOAA JacobCarley-NOAA Awaiting requested review from JacobCarley-NOAA JacobCarley-NOAA is a code owner

@BenjaminBlake-NOAA BenjaminBlake-NOAA Awaiting requested review from BenjaminBlake-NOAA BenjaminBlake-NOAA is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MatthewPyle-NOAA @ShunLiu-NOAA