-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add esnowanl to enkfgfs cycle #3283
base: develop
Are you sure you want to change the base?
Add esnowanl to enkfgfs cycle #3283
Conversation
Since I don't have the ability to request additional reviewers, feel free to look at this as well @CoryMartin-NOAA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just some minor suggestions, but looks ok to me.
Co-authored-by: Rahul Mahajan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks Travis for your efforts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Previously the esnowanl task was setup to run only for the enkfgdas cycle. This PR adds the capability for this task to run for the enkfgfs cycle, incorporating the rotating background directory structure used by other enkfgfs tasks.
Resolves #3276
Type of change
Change characteristics
How has this been tested?
3-4 cycles of an ATM with JEDI snow da experiment on Hera.
COMROOT: /scratch2/NCEPDEV/stmp3/Travis.J.Elless/comrot/test_snow_ec
EXPDIR: /scratch1/NCEPDEV/da/Travis.J.Elless/exp/test_snow_ec
Checklist