Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add esnowanl to enkfgfs cycle #3283

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

TravisElless-NOAA
Copy link
Contributor

Description

Previously the esnowanl task was setup to run only for the enkfgdas cycle. This PR adds the capability for this task to run for the enkfgfs cycle, incorporating the rotating background directory structure used by other enkfgfs tasks.

Resolves #3276

Type of change

  • New feature (adds functionality)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? NO
  • Does this change require a documentation update? NO
  • Does this change require an update to any of the following submodules? NO

How has this been tested?

3-4 cycles of an ATM with JEDI snow da experiment on Hera.
COMROOT: /scratch2/NCEPDEV/stmp3/Travis.J.Elless/comrot/test_snow_ec
EXPDIR: /scratch1/NCEPDEV/da/Travis.J.Elless/exp/test_snow_ec

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

@TravisElless-NOAA
Copy link
Contributor Author

Since I don't have the ability to request additional reviewers, feel free to look at this as well @CoryMartin-NOAA

Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some minor suggestions, but looks ok to me.

jobs/JGLOBAL_SNOWENS_ANALYSIS Outdated Show resolved Hide resolved
Copy link
Contributor

@jiaruidong2017 jiaruidong2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks Travis for your efforts.

@WalterKolczynski-NOAA WalterKolczynski-NOAA added the CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera label Jan 30, 2025
Copy link
Contributor

@aerorahul aerorahul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@emcbot emcbot added CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress and removed CI-Hera-Ready **CM use only** PR is ready for CI testing on Hera CI-Hera-Building **Bot use only** CI testing is cloning/building on Hera labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-Hera-Running **Bot use only** CI testing on Hera for this PR is in-progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update snow ensemble analysis to run for enkfgfs cycle
6 participants