Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable customizable idealized, doubly-periodic tests #909
base: develop
Are you sure you want to change the base?
Enable customizable idealized, doubly-periodic tests #909
Changes from 70 commits
d3521d5
2a3a156
5564af5
9b0c228
99c9579
c485881
7655fc5
fa5bfc6
4e524c8
81d33d9
40a3c66
3d721e8
2e0abb7
2dfb094
7901983
59c2453
23287bd
91daade
09f57a2
bb1207f
6613a8c
381f1c3
dd3d27c
574411a
6766fa0
8e5e159
aaea304
09dd2ff
157b1af
5cecf83
f85fad8
864fb1b
77d250d
9cdcb76
d90c372
652c0bf
cae9c22
12b6b8e
55d4b54
45de372
da84b17
d78bc9b
ba27e2b
28a4346
d6b7416
f03b664
e6a7a6c
2cd4f2d
0c8915a
3a688e3
01bb3e2
589b7bd
75abfcb
e8bc76b
ac265df
5df206d
e56385c
ef1101d
a6d4260
bfa340a
71e353d
85e8507
d5d075b
6fd8966
5fa7e69
2b4130f
2b6e9a8
406089e
3dac7b9
f86afff
09eb0f6
b21f6f0
bf9587b
3067624
69d16d0
b96c58f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this call needed here? There is already the same call on line 306 below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Call removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would write this if tests as:
if (Atmos%grid_type /= 4) then
Also, why grid with grid_type == 4 does not need grid coordinates, as other grid types? Is grid_type == 4 special in that regard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So originally this was bypassed because the ESMF coordinates have no bearing when the write component grid is never used, and it can't be used with these doubly periodic domains as they can have unrealistic (e.g., uniform) lat/lon configurations. However, I've pushed a fix that creates a single tile non-periodic ESMF grid for grid_type==4, and this now fills the ESMF coordinates correctly even if they're never used here.