turned on error message, fixed tests #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardhartnett
requested review from
Hang-Lei-NOAA,
EricJames-NOAA and
AlexanderRichert-NOAA
Hang-Lei-NOAA
approved these changes
Apr 18, 2024
Comment on lines
-42
to
43
| lvl_type1 = 'xxx' | ||
| lvl_type1 = 'surface' | ||
| scale_fac1 = 0 |
There was a problem hiding this comment.
Do these changes imply there are other scenarios that can also be tested, or were these details always "wrong"/not optimal?
There was a problem hiding this comment.
I was using xxx which was not a valid code and results in a 255 appearing in the output arrray.
I switch to using suface, which is a valid code, and causes a 1 to appear instead in the output array.
So we could test every valid value to ensure they are all correct...
But if we do that, it will be after the next release, which I am going to make today.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #113
Part of #116
turned on error message, fixed tests