Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add spack-based CI build #100

Merged
merged 8 commits into from
Oct 11, 2023
Merged

add spack-based CI build #100

merged 8 commits into from
Oct 11, 2023

Conversation

edwardhartnett
Copy link
Contributor

Fixes #99

@edwardhartnett edwardhartnett marked this pull request as ready for review October 8, 2023 17:22
@edwardhartnett
Copy link
Contributor Author

@AlexanderRichert-NOAA can you help me figure out how to fix the spack build? It needs to account for BUILD_SHARED_LIBS but I don't know how to do that.

@AlexanderRichert-NOAA
Copy link
Contributor

I added the variant/logic for it, but the setting is not currently by cmake. I believe the "STATIC" needs to be removed from the add_library line (line 39) in src/CMakeLists.txt.

@edwardhartnett edwardhartnett merged commit f62e0ef into develop Oct 11, 2023
8 checks passed
@edwardhartnett edwardhartnett deleted the ejh_spack branch October 11, 2023 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add spack-based CI build
3 participants