Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: dropping py37 support in favor of py312 #339

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kiraum
Copy link

@kiraum kiraum commented May 11, 2024

Hello! In a nutshell:

I recently attempted to build irrexplorer on py312, and had issues due frozenlist==1.3.3 not be supported/build for py312.
They started to support py312 on fronzenlist==1.4.0 onwards, due that, the proposed solution is to drop py37 support that's already end of life since 2023-06-27 in favor of py312.

To resolve this issue and enable support for py312, I propose the following changes:

  • Drop support for py37 in favor of py312. This will allow us to use the latest version of Python, and frozenlist compatibility will no longer be an issue.

  • Update the CircleCI pipeline configuration to reflect the changes in supported Python versions. However, I don't have access to the CircleCI pipeline, so this needs to be double-checked and updated accordingly.

  • I've included updated frontend/yarn.lock and poetry.lock files to include the necessary dependencies generated based in the new project requirements. I noticed that in the file history, these files have been updated both manually and automatically. Please ensure that the appropriate method is used to update these files.

  • Update the README file to reflect the changes in supported Python versions, updating supported Python version from 3.8 onwards.

  • Update the pyproject.toml file to specify the new Python version requirements.

From poetry:

The current project's supported Python range (>=3.7,<4.0) is not compatible with some of the required packages Python requirement:
  - frozenlist requires Python >=3.8, so it will not be satisfied for Python >=3.7,<3.8

Because irrexplorer depends on frozenlist (1.4.1) which requires Python >=3.8, version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

Thanks for this amazing project!

@kiraum
Copy link
Author

kiraum commented Sep 28, 2024

Should I keep or close this PR? If no answers, I will move forward and close it.

@teunvink
Copy link
Member

We have a meeting with our external developer next week on bugs, features and works for IRR Explorer in which we will also discuss this PR as well.

@mxsasha mxsasha self-assigned this Sep 30, 2024
MattKobayashi added a commit to MattKobayashi/containers that referenced this pull request Oct 8, 2024
MattKobayashi added a commit to MattKobayashi/containers that referenced this pull request Oct 8, 2024
MattKobayashi added a commit to MattKobayashi/containers that referenced this pull request Oct 8, 2024
* fix: Update `irrexplorer` to latest upstream

* fix: Python 3.12 not yet supported

Ref: NLNOG/irrexplorer#339

* fix: Use Alpine 3.19

* Run `poetry lock` before install

* Make `entrypoint.sh` executable

* Set owner of `entrypoint.sh`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants