Debugging2 #149
Merged
Debugging2 #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K20shores
reviewed
Apr 17, 2024
| @@ -22,7 +22,8 @@ | |||
| } | |||
| }, | |||
| "initial conditions": { | |||
| "initial_conditions.csv": {} | |||
| "PHOT.LOSS_SOA1 wall loss.s-1": 0.01, | |||
| "PHOT.LOSS_SOA2 wall loss.s-1": 0.05 | |||
There was a problem hiding this comment.
Why isn't this read in from the initial conditions file?
There was a problem hiding this comment.
This was how the box model was generating the config, however I can make it generate a file instead.
There was a problem hiding this comment.
I changed the config to use the initial_conditions.csv to store and read these configs.
K20shores
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configures initial conditions for reactions rates which was causing differing results in the Flow-Tube-Loss mechanism.