UFS-dev PR#220 #532
Open
UFS-dev PR#220 #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
@grantfirl Not sure what happened with the CI? I'm rerunning them now via workflow dispatch.
@dustinswales We're all good now after fixes that I put in #529 . |
|
CI RT output is identical as expected. |
dustinswales
approved these changes
Oct 22, 2024
mkavulich
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to NOAA-EMC/fv3atm#861 and NOAA-EMC/fv3atm#815
Note that fire coupling is not used/tested with the SCM, so changes from NOAA-EMC/fv3atm#815 are mainly superficial.
No regression test changes.