accept int64 time coordinates and print time coordinate differences #3
+132
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time coordinate units must start with seconds or microseconds to set the timestep explicitly. This is to support isfs hotfilm netcdf files.
use iterators instead of indexes to simplify time comparision loop and make it consistent with reporting loop, which revealed a bug in the reporting loop. add --showtimes option to report time coordinate differences, so previous --showindex output does not change. show right time coordinates with an offset to make it easier to follow times in left and right files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow comparing hotfilm netcdf files with an int64 time coordinate and units "microseconds since ...". Since the units have always been assumed to be "seconds", this code now enforces that the units must start with either "seconds" or "microseconds", and then it sets the time step accordingly. I don't think this should break other uses of
nc_compare, but it's the most likely potential impact.Time coordinate differences can be printed with the new
--showtimesoption, where before there was only a summary of the number of unique times in each file.basetime_from_units()could still be more robust about checking that the units string was correctly parsed, such as by checking thesscanf()andstrptime()return values, but I'll leave it for someone else to decide if that should be a separate issue. I guess it hasn't been a problem so far...