Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature update tutorial instructions #47

Merged
merged 34 commits into from
Aug 9, 2024

Conversation

jprestop
Copy link
Collaborator

@jprestop jprestop commented Aug 9, 2024

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Reviewed the changes in RTD (https://fasteddy-model.readthedocs.io/en/feature_update_tutorial_instructions/Tutorials/cases)

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    @jsauer-NCAR Please review the changes via the Files Changed tab and/or through RTD (https://fasteddy-model.readthedocs.io/en/feature_update_tutorial_instructions/Tutorials/cases). Please note that I only ran through the SBL dispersion case, but it looks like the instructions would be the same for the CBL case as well. Please let me know if you'd like me to run through the CBL case as well.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [at your convenience].

Pull Request Checklist

  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Select: Reviewer(s)
  • [No corresponding issue] After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added the pillar: community Community pillar issue label Aug 9, 2024
@jprestop jprestop added priority: medium Medium Priority requestor: Multiscale NWP Team Multiscale NWP Team type: task An actionable item of work labels Aug 9, 2024
@jprestop jprestop added this to the FastEddy 2.0 milestone Aug 9, 2024
@jprestop jprestop requested a review from jsauer-NCAR August 9, 2024 04:43
…tent associated with demostraition through the DISPERSION CBL case. Made a couple other minor documentation content modifications to fix typos and remove an uneccesary flag from the two FastEddy batch submission scripts.
@jprestop jprestop merged commit d19052a into develop Aug 9, 2024
2 checks passed
@jprestop jprestop deleted the feature_update_tutorial_instructions branch August 9, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pillar: community Community pillar issue priority: medium Medium Priority requestor: Multiscale NWP Team Multiscale NWP Team type: task An actionable item of work
Projects
None yet
2 participants