-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature update tutorial instructions #47
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_update_tutorial_instructions
jprestop
added
priority: medium
Medium Priority
requestor: Multiscale NWP Team
Multiscale NWP Team
type: task
An actionable item of work
labels
Aug 9, 2024
…tent associated with demostraition through the DISPERSION CBL case. Made a couple other minor documentation content modifications to fix typos and remove an uneccesary flag from the two FastEddy batch submission scripts.
jsauer-NCAR
approved these changes
Aug 9, 2024
This was
linked to
issues
Aug 9, 2024
This was referenced Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
pillar: community
Community pillar issue
priority: medium
Medium Priority
requestor: Multiscale NWP Team
Multiscale NWP Team
type: task
An actionable item of work
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Reviewed the changes in RTD (https://fasteddy-model.readthedocs.io/en/feature_update_tutorial_instructions/Tutorials/cases)
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
@jsauer-NCAR Please review the changes via the Files Changed tab and/or through RTD (https://fasteddy-model.readthedocs.io/en/feature_update_tutorial_instructions/Tutorials/cases). Please note that I only ran through the SBL dispersion case, but it looks like the instructions would be the same for the CBL case as well. Please let me know if you'd like me to run through the CBL case as well.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [at your convenience].
Pull Request Checklist