Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix lorenz_93 and lorenz_63 workshop input.nmls to have v11 version of namelist #793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hkershaw-brown
Copy link
Member

Description:

Added probit_transform_nml and algorithm_info_nml to the
input.workshop.nmls that were missing these (lorenz_63 and lorenz_96)
so the workshop_setup.sh scripts run to completion.

Updated the preprocess_nml to use obs_type quantity files.

Fixes issue

fixes #789

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Documentation changes needed?

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.

Tests

Please describe any tests you ran to verify your changes.

Ran all the workshop_setup.sh script

Checklist for merging

  • Updated changelog entry
  • Documentation updated
  • Update conf.py

Checklist for release

  • Merge into main
  • Create release from the main branch with appropriate tag
  • Delete feature-branch

Testing Datasets

  • Dataset needed for testing available upon request
  • Dataset download instructions included
  • No dataset needed

@hkershaw-brown hkershaw-brown added the release! bundle with next release label Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release! bundle with next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workshop_setup.sh scripts (input.workshop.nml) is out-of-date (v10 vs v11 qceff)
1 participant