[frontend] Replace calls to deprecated function getAlignment (#304).
#309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanperez-keera
changed the title
frontend: Replace calls to deprecated getAlignment (#304).frontend: Replace calls to deprecated getAlignment (#304).
…-VnV#304). The function llvm::AllocaInst::getAlignment was deprecated in llvm-14 and removed in llvm-15. To facilitate IKOS working with newer versions of llvm, we should replace calls to getAlignment(). This commit replaces several occurrences of getAlignment with calls to getAlign().value(). The replacement is only applied in cases where it is clear that the an alignment exists (the function getAlign returns an Align), as opposed to places where the alignment may be optional (where the function getAlign returns a MaybeAlign).
ivanperez-keera
force-pushed
the
develop-getAlignment
branch
from
5a84130 to
900403e
Compare
ivanperez-keera
changed the title
frontend: Replace calls to deprecated getAlignment (#304).getAlignment (#304).
ivanperez-keera
changed the title
getAlignment (#304).[frontend] Replace calls to deprecated function getAlignment (#304).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function llvm::AllocaInst::getAlignment was deprecated in llvm-14 and removed in llvm-15. To facilitate IKOS working with newer versions of llvm, we should replace calls to getAlignment() with calls to getAlign().value().
This commit replaces several occurrences of getAlignment with calls to getAlign. The replacement only occurs in cases where it is clear that the expansion is possible (there is an alignment). Other calls (e.g., when the call returns an optional value) are not replaced, since there is a disagreement between the current implementation of
getAlignmentfor those classes in terms of the newgetAlignand the current interface ofMaybeAlign.