Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/972 center time range on span #991

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Feature/972 center time range on span #991

merged 3 commits into from
Nov 9, 2023

Conversation

duranb
Copy link
Collaborator

@duranb duranb commented Nov 8, 2023

resolves #972

To test:

  1. Create a plan and add some directives
  2. Run the simulation to generate spans
  3. Right click on a span
  4. Verify that a context menu appears with the item "Center around Simulated Activity"
  5. Verify that clicking on one of the submenu items centers the view around that span with the specified time duration padding on both sides

@duranb duranb requested a review from a team as a code owner November 8, 2023 19:44
AaronPlave
AaronPlave approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@AaronPlave AaronPlave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about phrasing but otherwise LGTM

@duranb duranb force-pushed the feature/972-center-time-range-on-span branch from 5c09231 to 58b498e Compare November 9, 2023 18:23
@duranb duranb force-pushed the feature/972-center-time-range-on-span branch from 58b498e to f2942f2 Compare November 9, 2023 18:48
@duranb duranb merged commit b479317 into develop Nov 9, 2023
4 checks passed
@duranb duranb deleted the feature/972-center-time-range-on-span branch November 9, 2023 19:15
JosephVolosin pushed a commit that referenced this pull request Aug 20, 2024
@duranb
Feature/972 center time range on span (#991)
c82d53b 
* add context menu for centering view around selected spans with time padding
* delay context menu for activities to allow selection event to occur first
JosephVolosin pushed a commit that referenced this pull request Oct 21, 2024
@duranb @JosephVolosin
Feature/972 center time range on span (#991)
16034f8 
* add context menu for centering view around selected spans with time padding
* delay context menu for activities to allow selection event to occur first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AaronPlave AaronPlave AaronPlave approved these changes

@dandelany dandelany Awaiting requested review from dandelany dandelany is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

@joswig joswig Awaiting requested review from joswig joswig is a code owner automatically assigned from NASA-AMMOS/aerie-frontend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Center View on Selected Span
2 participants
@duranb @AaronPlave