Subscription store fixes #1593
Merged
Subscription store fixes #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
fix/1464/subscription-fixes
branch
from
b20b724 to
1985a19
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Jan 17, 2025
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
had a problem deploying
to
test-workflow
GitHub Actions
Failure
AaronPlave
force-pushed
the
fix/1464/subscription-fixes
branch
from
55fe331 to
c580687
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
🤞 |
AaronPlave
force-pushed
the
fix/1464/subscription-fixes
branch
from
c580687 to
b60a4df
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
fix/1464/subscription-fixes
branch
from
b60a4df to
b5e7a81
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors gql subscription store so that the store only maintains a single subscription to the query within the web socket instead of N subscriptions where N is the number of files that the store is used within. This removes redundant subscriptions which could potentially cause performance issues in many cases. Note that the debugging of this code was difficult and that the current solution relies on debounce the creation of new subscriptions since the underlying graphql websocket library seems to not always be able to immediately execute unsubscribe calls which can cause duplication of queries and in some cases unsubscription from the incorrect queries.
Closes #1464.