View subscription refactor and bug fixes #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
4ed879e to
0a2af0f
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
reviewed
Nov 30, 2023
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
0a2af0f to
0e35a23
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
0e35a23 to
ac81c1d
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
ac81c1d to
2aa76b3
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
duranb
requested changes
Dec 8, 2023
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
c1d4848 to
7a9a9f6
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
…demand. Fix bug with deletion of views.
AaronPlave
force-pushed
the
feat/view-loading-perf-and-fixes
branch
from
7a9a9f6 to
b9c758d
Compare
AaronPlave
temporarily deployed
to
test-workflow
GitHub Actions
Inactive
JosephVolosin
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Use capture for context menu keydown and stop propagation on escape keydown if shown * Do not include view definition in view subscription and full view on demand. * Fix bug with deletion of views. * Fix delete view permissions check
JosephVolosin
pushed a commit
that referenced
this pull request
Oct 21, 2024
* Use capture for context menu keydown and stop propagation on escape keydown if shown * Do not include view definition in view subscription and full view on demand. * Fix bug with deletion of views. * Fix delete view permissions check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #1012 by resolving the underlying performance issue with the view subscription. Previously the view subscription included view definitions but this PR removes definitions from the subscription and instead fetches the full view on demand. This PR also fixes:
userViewslist since the admin might not be the owner of the view but could still have delete permissions (which will be checked downstream anyway).