crawler_valor #85
Open
crawler_valor #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to repeat this code in every crawler.
| index = requests.get(INDEX_URL).content | ||
| soup = BeautifulSoup(index, "lxml") | ||
| news_index = soup.find(id="block-valor_capa_automatica-central_automatico").find_all('h2') | ||
| news_urls = news_urls + ['http://www.valor.com.br' + BeautifulSoup( art.encode('utf8') , "lxml" ).find('a').attrs['href'] for art in news_index] |
There was a problem hiding this comment.
It might be a good idea to break this line to make it more readable. PEP8 suggests 72 with a maximum of 79. I like to follow that whenever possible.
|
I think that, apart from the really small issues I pointed out in line comments, the code looks good and we should merge it. |
|
Also, another really important thing: please use 4 spaces instead of tab. I have no real problem with tabs, but mixing spaces and tabs are a bad idea, and our entire code base is using spaces. If you use vim you can use spaces by adding To your |
| from bs4 import BeautifulSoup | ||
| import requests | ||
| import re | ||
| import pandas as pd |
There was a problem hiding this comment.
You don't need to import re nor pandas. It's a good idea to remove these imports.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created this crawler for Valor. Please check if it's ok. I try to take in count the coments on @lucasmachadorj pull request.