Logging cleanup and add options to force long console log format #604
Conversation
|
The format is currently Also, I think replacing |
|
It probably goes without saying but we need to be careful not to add too much extra processing of each log message because with the debug level enabled the logs can get very verbose and if you don't have a supercomputer then the logging just bog down the system making it harder to debug the problem you are trying to look at. |
|
As the changes currently stand, the FileLogger has an extra function call to generate the log message because it is not inline, but I don't consider that a noticeable increase because of the two QString function calls which malloc. logConsole() has an extra if statement.
Adding the LOG_LEVEL would, in my opinion, be useful for narrowing down what verbose arguments are needed when starting from |
|
Rebased onto master without change to force rebuild. |
|
Rebased onto master and fixed a typo in a Doxygen comment. |
|
I have found it challenging to discover where in the huge code base certain things happen. Seems like this feature could make that much easier. I might not want larger logs in production but it would be a nice option when trying to find a bug or feature to tweak. |
|
Rebased onto master. I don't know what would be necessary to always force the long log format when using CMake. |
by replacing the write system call, which may only partially write, with the C++ standard iostreams.
which it doesn't need to be.
The POSIX write() system call may truncate the output. The proper way to use it is in a loop. Instead, use the high level C++ STL I/O. The Boost library would be needed to keep using the open() and close() system calls, i.e. to wrap a FILE* with an iostream. I don't see a way via the C++ STL ofstream to set the Unix file permissions. However, it seems to default to the previously specified 0664. I'm not sure how to test that FileLogger::reopen() actually works with a log roller, but it should be equivalent.
between console and file logging. The new shared long log format is the logConsole format.
Initially for compatibility with FFmpeg's log levels, but should also be useful in MythTV.
It was asked on IRC if there was an option to make the console log output include the line numbers, etc. in the last month or so, although I couldn't find it again.
The first part replaces the use of the
writesystem call, which may truncate the output.The second part adds the new compile-time and run-time options to force the long log format. I am open to other name suggestions for the command-line flag and its corresponding variables.
Also, if there are any preferences for a different long log format, now is the time to change it.
As usual, see commits for details.
Checklist