Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SEINT-275 Add http headers default cache-control to public, max-age=3600 #333

Closed
wants to merge 4 commits into from

Conversation

VLegakis
Copy link

No description provided.

@VLegakis VLegakis self-assigned this Dec 18, 2024
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
walrus-sites-sp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:47am
walrus-sites-sp-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:47am
walrus-sites-sw ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:47am
walrus-sites-sw-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 0:47am

@VLegakis VLegakis changed the title Add http headers default cache-control to public, max-age=3600 SEINT-275 Add http headers default cache-control to public, max-age=3600 Dec 18, 2024
@VLegakis VLegakis changed the title SEINT-275 Add http headers default cache-control to public, max-age=3600 feat(site-builder):SEINT-275 Add http headers default cache-control to public, max-age=3600 Dec 18, 2024
Copy link

codspeed-hq bot commented Dec 18, 2024

CodSpeed Performance Report

Merging #333 will not alter performance

Comparing vl/SEINT-275-caching (a2bf444) with main (cae751f)

Summary

✅ 3 untouched benchmarks

@VLegakis
Copy link
Author

After discussion with @Tzal3x we decided to leave this default cache-control policy for the future. Lets leave this PR open-pending and we decide depending on the type of sites being published.

@VLegakis VLegakis marked this pull request as ready for review January 7, 2025 14:51
@VLegakis VLegakis requested review from Tzal3x and giac-mysten January 7, 2025 14:51
@VLegakis VLegakis changed the title feat(site-builder):SEINT-275 Add http headers default cache-control to public, max-age=3600 feat(site-builder): SEINT-275 Add http headers default cache-control to public, max-age=3600 Jan 7, 2025
@VLegakis VLegakis changed the title feat(site-builder): SEINT-275 Add http headers default cache-control to public, max-age=3600 feat: SEINT-275 Add http headers default cache-control to public, max-age=3600 Jan 8, 2025
@Tzal3x
Copy link
Collaborator

Tzal3x commented Jan 10, 2025

@VLegakis, for now we decided not to include defaults, because we would like to align with current developer common practices.

Take as an example vercel deployments where caching headers are not added to the responses by default.

Implicit/default caching can still be added on the portal level by defining them on next.config.js, without touching the site-builder. But this is something to be taken into account in another phase.

Closing this PR as it's no longer relevant. Thank you regardless! 🙇‍♂️

@Tzal3x Tzal3x closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants