-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat(site-builder): add permanent flag in site-builder publish command #320
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
CodSpeed Performance ReportMerging #320 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the project @VLegakis!
Despite this being still a WIP, here is an early comment:
Regarding deletable sites in walrus, based on this discussion, we might need the opposite of what is implemented currently.
i.e. instead of publishing sites as deletable with a --deletable
flag, we should always publish them as deletable by default, unless specified otherwise with --permanent
.
Though they are not exactly permanent, as they will still get deleted when their epoch expires.
@giac-mysten do you think --only-expirable
instead of --permanent
would better depict the actual site lifetime being set?
Also, please check out CONTRIBUTING.md and follow how to set your |
@Tzal3x good question. "Permanent" is official Walrus terminology. When you So i'd say |
…228-deletable-blobs
site-builder
delete
command needs to be added.