Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add client-request-method to CORS allowed headers (#20160) #20168

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

johnjmartin
Copy link
Contributor

Description

adds client-request-method to allowed cors methods

Test plan


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

Description

Describe the changes or additions included in this PR.

Test plan

How did you test the new or updated feature?


Release notes

Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.

For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.

  • Protocol:
  • Nodes (Validators and Full nodes):
  • Indexer:
  • JSON-RPC:
  • GraphQL:
  • CLI:
  • Rust SDK:
  • REST API:

## Description 

adds `client-request-method` to allowed cors methods

## Test plan 


---

## Release notes

Check each box that your changes affect. If none of the boxes relate to
your changes, release notes aren't required.

For each box you select, include information after the relevant heading
that describes the impact of your changes that a user might notice and
any actions they must take to implement updates.

- [ ] Protocol: 
- [ ] Nodes (Validators and Full nodes): 
- [ ] Indexer: 
- [ ] JSON-RPC: 
- [ ] GraphQL: 
- [ ] CLI: 
- [ ] Rust SDK:
- [ ] REST API:
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sui-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 10:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:13pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:13pm
sui-typescript-docs ⬜️ Ignored (Inspect) Visit Preview Nov 4, 2024 10:13pm

@johnjmartin johnjmartin temporarily deployed to sui-typescript-aws-kms-test-env November 4, 2024 20:40 — with GitHub Actions Inactive
@ebmifa ebmifa temporarily deployed to sui-typescript-aws-kms-test-env November 4, 2024 22:11 — with GitHub Actions Inactive
@johnjmartin johnjmartin merged commit 7839b95 into releases/sui-v1.37.0-release Nov 4, 2024
51 of 52 checks passed
@johnjmartin johnjmartin deleted the jjm/cp-cors branch November 4, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants