[move-ide] Custom compiler edition notification #20146
Open
+190
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
awelc
temporarily deployed
to
sui-typescript-aws-kms-test-env
GitHub Actions
Inactive
tnowacki
reviewed
Nov 4, 2024
Comment on lines
+36
to
+39
| pub struct EditionInfo { | ||
| pub edition: String, | ||
| pub release: Option<String>, | ||
| } |
There was a problem hiding this comment.
Any reason not to use move-compiler::editions::Edition?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements support for passing custom notifications from LSP server to the IDE and an example of how this kind of notification can be handled on the IDE side (in this case on the VSCode side, and the handler simply logs the edition to the client log). In order to do it, I generalized the notification machinery between the symbolicator thread and the main
move-analyzerthread a bitTest plan
All existing tests must pass